https://github.com/libp2p/js-libp2p-webrtc-star/issues/186 #187
Conversation
query: {
wrtcstar: true,
},
…erver also add wrtcstar=true to a querystring
There was a problem hiding this comment.
Thanks for the PR @pashoo2
Also, can you fix the linting issues to get this merged?
| @@ -42,7 +42,10 @@ class WebRTCStar { | |||
|
|
|||
| this.sioOptions = { | |||
There was a problem hiding this comment.
Can you remove this object? It stayed here before by mistake, but if you have a look, it is not being used anywhere
There was a problem hiding this comment.
Sorry, i was in hospital for the last week and was't see any comments. I'll do it tomorrow, when I'll be at home
There was a problem hiding this comment.
Yes, the object does't used, i thought it's for a use in a future. E.g. it can be usefull if the library Will provide functionality to use a custom options for a socket.io connections.
|
Hey @pashoo2 thanks for trying to land this. IF you are still interested in this, please submit a new PR as we completely refactored this module |
added param ?webrtcstar=true to requests to a signal server