Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

https://github.com/libp2p/js-libp2p-webrtc-star/issues/186 #187

Closed
wants to merge 2 commits into from
Closed

https://github.com/libp2p/js-libp2p-webrtc-star/issues/186 #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa6ba2f
added query string wrtcstar=true for queries to a signal server
pashoo2 Oct 18, 2019
68bd8a2
also add wrtcstar=true to a querystring when connecting to a signal s…
pashoo2 Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ class WebRTCStar {

this.sioOptions = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this object? It stayed here before by mistake, but if you have a look, it is not being used anywhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i was in hospital for the last week and was't see any comments. I'll do it tomorrow, when I'll be at home

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the object does't used, i thought it's for a use in a future. E.g. it can be usefull if the library Will provide functionality to use a custom options for a socket.io connections.

transports: ['websocket'],
'force new connection': true
'force new connection': true,
query: {
wrtcstar: true,
},
}

if (options.wrtc) {
Expand Down
5 changes: 4 additions & 1 deletion src/listener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ const { cleanUrlSIO } = require('./utils')

const sioOptions = {
transports: ['websocket'],
'force new connection': true
'force new connection': true,
query: {
wrtcstar: true,
},
}

module.exports = ({ handler, upgrader }, WebRTCStar, options = {}) => {
Expand Down