Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Support for port 0 and host 0.0.0.0 #12

Closed
dignifiedquire opened this issue May 11, 2016 · 4 comments
Closed

Support for port 0 and host 0.0.0.0 #12

dignifiedquire opened this issue May 11, 2016 · 4 comments
Assignees
@dryajov
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@dignifiedquire
Copy link
Member

  • Add tests for 0.0.0.0
  • Support returning the actual bound port if port 0 is being used
@daviddias daviddias added the kind/enhancement A net-new feature or improvement to an existing feature label Jun 20, 2016
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Sep 7, 2016
@daviddias daviddias added exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue and removed libp2p-backlog labels Jul 7, 2017
@daviddias daviddias mentioned this issue Sep 16, 2017
Closed
@dryajov dryajov self-assigned this Sep 16, 2017
@dryajov
Copy link
Member

dryajov commented Sep 16, 2017

This requires changing the underlying pull-stream/pull-ws to expose server.address. A PR to accomplish this is here - pull-stream/pull-ws#21

@dryajov
Copy link
Member

dryajov commented Sep 16, 2017

This PR should address resolving 0 addrs - #64

This was referenced Sep 16, 2017
Merged
Merged
@daviddias
Copy link
Member

Woot, thank you @dryajov \o/

@daviddias daviddias added the P2 Medium: Good to have, but can wait until someone steps up label Oct 20, 2017
@daviddias
Copy link
Member

released in v0.10.2

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dryajov dryajov

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dignifiedquire @dryajov @daviddias @fbaiodias