Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose .address from underlying server #21

Merged
merged 3 commits into from
Sep 19, 2017
Merged

feat: expose .address from underlying server #21

merged 3 commits into from
Sep 19, 2017

Conversation

dryajov
Copy link
Contributor

@dryajov dryajov commented Sep 16, 2017 •
edited
Loading

Currently there is not way of telling what is the resolved address after the server has been created. Exposing .address from the underlying server should allow for this, which is handy for 0 ports.

This was referenced Sep 16, 2017
Closed
Merged
@dryajov
Copy link
Contributor Author

dryajov commented Sep 16, 2017

This is required for - libp2p/js-libp2p-websockets#12

@dominictarr dominictarr merged commit 87e4720 into pull-stream:master Sep 19, 2017
@dominictarr
Copy link
Member

thanks! merged into 3.3.0

@dryajov
Copy link
Contributor Author

dryajov commented Sep 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dryajov @dominictarr