Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move services to separate packages #1913

Closed
9 tasks
Tracked by #2081
, #2104
...
maschad opened this issue Jul 31, 2023 · 1 comment
Closed
9 tasks
Tracked by #2081
, #2104
...

refactor: move services to separate packages #1913

maschad opened this issue Jul 31, 2023 · 1 comment
Assignees
@wemeetagain @maschad
Labels
kind/discussion Topical discussion; usually not changes to codebase topic/docs Documentation

Comments

@maschad
Copy link
Member

maschad commented Jul 31, 2023 •
edited by achingbrain
Loading

There are a few internal services such as identify , Address Manager, Pnet and others in the libp2p package which have their own README that contains descriptions about how to configure the services. Because they are buried a few subdirectories down in the libp2p package they have low discoverability and so that information should be extracted to the top level docs as well as their usage should be generated by our docs tooling. This also unnecessarily bloates the libp2p npm package.

Related: #1910 (review)

Packages:

Tasks
Beta Give feedback
@maschad maschad added need/triage Needs initial labeling and prioritization kind/discussion Topical discussion; usually not changes to codebase topic/docs Documentation labels Jul 31, 2023
@maschad maschad removed the need/triage Needs initial labeling and prioritization label Sep 12, 2023
This was referenced Sep 30, 2023
Open
Closed
Closed
Merged
@wemeetagain wemeetagain changed the title Docs: Add Internal Services Descriptions and Configurations to Configuration Doc refactor: move services to separate packages Oct 2, 2023
This was referenced Oct 3, 2023
Closed
Closed
@wemeetagain wemeetagain mentioned this issue Oct 20, 2023
Merged
3 tasks
@maschad maschad self-assigned this Oct 27, 2023
achingbrain pushed a commit that referenced this issue Oct 31, 2023
@wemeetagain
refactor!: move pnet into separate package (#2165)
5178617 
- Move pnet module to a separate package
- Related to #1913
maschad added a commit to maschad/js-libp2p that referenced this issue Nov 3, 2023
@maschad
refactor!: move fetch into seperate package (libp2p#1913)
102c8f1
achingbrain pushed a commit that referenced this issue Nov 3, 2023
@wemeetagain @achingbrain
refactor!: move pnet into separate package (#2165)
ce6ee74 
- Move pnet module to a separate package
- Related to #1913
achingbrain pushed a commit to maschad/js-libp2p that referenced this issue Nov 3, 2023
@maschad @achingbrain
refactor!: move fetch into seperate package (libp2p#1913)
8b47a2c
achingbrain pushed a commit to maschad/js-libp2p that referenced this issue Nov 3, 2023
@maschad @achingbrain
refactor!: move fetch into seperate package (libp2p#1913)
60165d4
achingbrain pushed a commit to maschad/js-libp2p that referenced this issue Nov 3, 2023
@maschad @achingbrain
refactor!: move fetch into seperate package (libp2p#1913)
0e04402
achingbrain pushed a commit to maschad/js-libp2p that referenced this issue Nov 3, 2023
@maschad @achingbrain
refactor!: move fetch into seperate package (libp2p#1913)
0cb7368
@achingbrain achingbrain linked a pull request Nov 10, 2023 that will close this issue
chore: release v1.0.0 #2144
Closed
@achingbrain
Copy link
Member

This has been completed in the v1.0.0 release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wemeetagain wemeetagain

@maschad maschad

Labels
kind/discussion Topical discussion; usually not changes to codebase topic/docs Documentation
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: release v1.0.0 libp2p/js-libp2p
3 participants
@achingbrain @wemeetagain @maschad