Tcp refinements #404
Merged
Tcp refinements #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
twittner
reviewed
Aug 9, 2018
tcp-transport/src/lib.rs
Outdated
| Ok((Box::new(future), new_addr)) | ||
| let inner = listener | ||
| .map_err(Some) | ||
| .map(|l| l.incoming().sleep_on_error(Duration::from_secs(1))); |
There was a problem hiding this comment.
This should be updated to use TcpConfig::sleep_on_error.
tcp-transport/src/lib.rs
Outdated
| let proto2 = match iter.next() { | ||
| Some(v) => v, | ||
| None => return Err(()), | ||
| }; |
There was a problem hiding this comment.
How about:
let proto1 = iter.next().ok_or(())?;
let proto2 = iter.next().ok_or(())?;
twittner
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of an effort to remove boxes from the crate. cc #369
You can review commit by commit, especially as there's a
cargo fmtin the middle of the stack.