Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Send/Sync situation #369

Closed
tomaka opened this issue Jul 25, 2018 · 2 comments
Closed

The Send/Sync situation #369

tomaka opened this issue Jul 25, 2018 · 2 comments
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Jul 25, 2018

Right now we use lots of Boxes at various locations in the library, but most of them are not Send or Sync. This should be changed, or the boxes removed.
This was referenced Aug 7, 2018
Closed
Merged
Closed
Merged
Merged
@tomaka tomaka mentioned this issue Aug 16, 2018
Merged
@tomaka tomaka mentioned this issue Sep 5, 2018
Merged
@tomaka tomaka mentioned this issue Nov 16, 2018
Merged
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project and removed P-oneday labels Nov 30, 2018
@twittner twittner mentioned this issue Dec 3, 2018
Merged
@tomaka
Copy link
Member Author

tomaka commented Feb 21, 2019

The only Box<Future> left are in protocols/observed and transports/websocket/browser.

@tomaka tomaka added the getting-started Issues that can be tackled if you don't know the internals of libp2p very well label Feb 21, 2019
@tomaka tomaka mentioned this issue May 31, 2019
Merged
@romanb
Copy link
Contributor

romanb commented Oct 26, 2020

The only Box left are in protocols/observed and transports/websocket/browser.

That code no longer exists. I think if there is something specific left to do here, we should create new issues that target specific uses of Boxes. Feel free to reopen if you think this issue should still be kept open, despite its generality.

@romanb romanb closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnunicorn @romanb @tomaka