Complements to #389 #415
Merged
Complements to #389 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
suggested changes
Aug 14, 2018
secio/src/stream_cipher.rs
Outdated
| @@ -1,6 +1,26 @@ | |||
| // Copyright 2017 Parity Technologies (UK) Ltd. | |||
secio/src/codec/mod.rs
Outdated
| @@ -35,7 +35,7 @@ mod encode; | |||
| /// Type returned by `full_codec`. | |||
| pub type FullCodec<S> = DecoderMiddleware<EncoderMiddleware<length_delimited::Framed<S>>>; | |||
|
|
|||
| pub type StreamCipher = StreamCipherCore; | |||
| pub type StreamCipher = Box<dyn StreamCipherCore>; | |||
There was a problem hiding this comment.
Could you do Box<dyn StreamCipherCore + Send> while you're at it? cc #369
tomaka
approved these changes
Aug 15, 2018
ghost
assigned 
rphmeier
reviewed
Aug 15, 2018
| @@ -35,7 +35,7 @@ mod encode; | |||
| /// Type returned by `full_codec`. | |||
| pub type FullCodec<S> = DecoderMiddleware<EncoderMiddleware<length_delimited::Framed<S>>>; | |||
|
|
|||
| pub type StreamCipher = StreamCipherCore; | |||
| pub type StreamCipher = Box<dyn StreamCipherCore + Send>; | |||
There was a problem hiding this comment.
It was stabilized in Rust 1.27. Not using dyn will become deprecated at the end of the year I think.
There was a problem hiding this comment.
Yes, according to the Rust 2018 roadmap.
There was a problem hiding this comment.
Should we note somewhere that we are expecting you to use latest rust stable (or at least 1.27+)?
There was a problem hiding this comment.
It should be in the CI if we do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cosmetic fix and the missing copyright for #386