Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the tokio_current_thread crate in the tests #399

Closed
tomaka opened this issue Aug 7, 2018 · 1 comment
Closed

Don't use the tokio_current_thread crate in the tests #399

tomaka opened this issue Aug 7, 2018 · 1 comment

Comments

@tomaka
Copy link
Member

tomaka commented Aug 7, 2018

It's indeed not supposed to be used directly.
The problem is that nothing implements Send and Sync (cc #369) so we have to use a runtime that doesn't require them.
Fortunately we can just use tokio::runtime::current_thread::Runtime.

@tomaka tomaka changed the title Don't use the tokio_current_thread crate Don't use the tokio_current_thread crate in the tests Aug 7, 2018
tomaka added a commit to jamartin9/rust-libp2p that referenced this issue Oct 20, 2018
jamartin9 pushed a commit to jamartin9/rust-libp2p that referenced this issue Oct 24, 2018
tomaka pushed a commit that referenced this issue Oct 25, 2018
* remove tokio_current_thread tests

* Review changes:
Removed newline
Moved uds tokio test crate to top to avoid self and keep with convention of other test crates
Removed sleep from uds test and block until all futures are completed.
dvdplm added a commit to dvdplm/rust-libp2p that referenced this issue Oct 29, 2018
…e-handled_node

* upstream/master:
  Add protocol to report external address view. (libp2p#566)
  Add a TransportExt trait (libp2p#533)
  libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm added a commit to dvdplm/rust-libp2p that referenced this issue Oct 29, 2018
…e-handled_node_tasks

* upstream/master:
  Add protocol to report external address view. (libp2p#566)
  Add a TransportExt trait (libp2p#533)
  libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm added a commit to dvdplm/rust-libp2p that referenced this issue Oct 29, 2018
…lection_stream

* upstream/master:
  Add protocol to report external address view. (libp2p#566)
  Add a TransportExt trait (libp2p#533)
  libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm added a commit to dvdplm/rust-libp2p that referenced this issue Nov 1, 2018
…ref-debug-impl

* upstream/master:
  Use paritytech/rust-secp256k1 (libp2p#598)
  Use websocket 0.21.0 (libp2p#597)
  Reexport multihash from the facade (libp2p#587)
  Add substrate to the list of projects using libp2p (libp2p#595)
  Remove spaces before semicolons (libp2p#591)
  Add protocol to report external address view. (libp2p#566)
  Add a TransportExt trait (libp2p#533)
  libp2p#399 remove tokio_current_thread tests (libp2p#577)
  Remove even more unused files (libp2p#581)
  Fix the polling process in handled node (libp2p#582)
  Fix panicking when Kad responder is destroyed (libp2p#575)
  Remove other unused files (libp2p#570)
  Fix panic in raw swarm (libp2p#571)
  Remove two unused files (libp2p#567)
  New core (libp2p#568)
  Remove the old API (libp2p#565)
  Change some `nat_traversal`s to consider a prefix. (libp2p#550)
  Add some documentation to listeners stream (libp2p#547)
  Add shutdown functionality to `NodeStream`. (libp2p#560)
@tomaka
Copy link
Member Author

tomaka commented Nov 5, 2018

Done in #577

@tomaka tomaka closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant