Add protocol to report external address view. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be rebased over |
tomaka
reviewed
Oct 17, 2018
protocols/observed/src/lib.rs
Outdated
| type Future = Box<dyn Future<Item=(Self::Output, Self::MultiaddrFuture), Error=io::Error> + Send>; | ||
|
|
||
| fn protocol_names(&self) -> Self::NamesIter { | ||
| iter::once((Bytes::from("/observed-address/0.1.0"), ())) |
There was a problem hiding this comment.
Since this is "experimental", I think we should have a "non-standard" protocol name.
Suggested change
| iter::once((Bytes::from("/observed-address/0.1.0"), ())) | |
| iter::once((Bytes::from("/paritytech/observed-address/0.1.0"), ())) |
protocols/observed/src/lib.rs
Outdated
| /// As `Dialer`, we get our own externally observed address. | ||
| ObservedAddr(Multiaddr), | ||
| /// As `Listener`, we return the underlying resource. | ||
| Resource(Framed<C, UviBytes>) |
There was a problem hiding this comment.
This should be an object that wraps around the Framed<C, UviBytes> and allows the user to send the multiaddress.
Address part of libp2p#443.
twittner
force-pushed
the
observed-address
branch
from
f8fd0f6 to
cba7101
Compare
tomaka
suggested changes
Oct 19, 2018
protocols/observed/src/lib.rs
Outdated
|
|
||
| impl<C: AsyncWrite> Sender<C> { | ||
| /// Send address `a` to remote as the observed address. | ||
| pub fn send_address(self, a: &Multiaddr) -> impl Future<Item=C, Error=io::Error> { |
There was a problem hiding this comment.
I don't think this should have a return value. We want to enforce the protocol's correct behaviour (which is to close the substream afterwards) in the API.
Also, taking ownership of the Multiaddr removes one copy.
protocols/observed/src/lib.rs
Outdated
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| extern crate tokio_current_thread; |
There was a problem hiding this comment.
Since there's already a PR to replace this with tokio (#577), I think you should do it here as well.
|
Test failure is unrelated ( |
tomaka
approved these changes
Oct 20, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 29, 2018
…e-handled_node * upstream/master: Add protocol to report external address view. (libp2p#566) Add a TransportExt trait (libp2p#533) libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 29, 2018
…e-handled_node_tasks * upstream/master: Add protocol to report external address view. (libp2p#566) Add a TransportExt trait (libp2p#533) libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 29, 2018
…lection_stream * upstream/master: Add protocol to report external address view. (libp2p#566) Add a TransportExt trait (libp2p#533) libp2p#399 remove tokio_current_thread tests (libp2p#577)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 1, 2018
…ref-debug-impl * upstream/master: Use paritytech/rust-secp256k1 (libp2p#598) Use websocket 0.21.0 (libp2p#597) Reexport multihash from the facade (libp2p#587) Add substrate to the list of projects using libp2p (libp2p#595) Remove spaces before semicolons (libp2p#591) Add protocol to report external address view. (libp2p#566) Add a TransportExt trait (libp2p#533) libp2p#399 remove tokio_current_thread tests (libp2p#577) Remove even more unused files (libp2p#581) Fix the polling process in handled node (libp2p#582) Fix panicking when Kad responder is destroyed (libp2p#575) Remove other unused files (libp2p#570) Fix panic in raw swarm (libp2p#571) Remove two unused files (libp2p#567) New core (libp2p#568) Remove the old API (libp2p#565) Change some `nat_traversal`s to consider a prefix. (libp2p#550) Add some documentation to listeners stream (libp2p#547) Add shutdown functionality to `NodeStream`. (libp2p#560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of #443.