Add a peer id generator #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
reviewed
Oct 23, 2018
misc/peer-id-generator/src/main.rs
Outdated
| let prefix = match env::args().nth(1) { | ||
| Some(prefix) => prefix, | ||
| None => { | ||
| println!("Usage: {} <prefix>", env::args().nth(0).unwrap()); |
There was a problem hiding this comment.
"Usage {} , where prefix is a sequence of letters/numbers from the Base58 alfabet, starting with one of NPQRSTUVWXYZ"
misc/peer-id-generator/src/main.rs
Outdated
| } | ||
|
|
||
| // Due to the fact that a peer id uses a SHA-256 multihash, it always starts with the | ||
| // bytes 0x1220, meaning that only some characters are valid. |
There was a problem hiding this comment.
Is this why the peer id always start with Qm too?
|
Should also mention that it's only secp256k1. |
twittner
approved these changes
Oct 30, 2018
| } | ||
|
|
||
| loop { | ||
| thread::sleep(Duration::from_secs(3600)); |
There was a problem hiding this comment.
Instead of executing for a certain amount of time, would you not rather want to generate a specific number of keys? How about a second command line parameter to specific that number and then maybe utilise rayon with (0 .. number).into_par_iter().for_each(move |_| ...)?
There was a problem hiding this comment.
Generating keys is super slow, so I don't think it really makes sense to stop after a certain number.
Do you think I should use rayon?
There was a problem hiding this comment.
Rayon works well but I was only suggesting it in the context of "I want n peer IDs". If you rather prefer time-based execution the existing approach is fine I think.
tomaka
added a commit
to tomaka/libp2p-rs
that referenced
this pull request
Nov 5, 2018
* Add a peer id generator * Improve usage message * Better help * Rustfmt
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 6, 2018
…e-handled_node_tasks * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 6, 2018
…rs-to-vecdeque * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 7, 2018
…_swarm * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 9, 2018
…lection_stream * upstream/master: Use vecdeque for fair polling (libp2p#610) Add back the Swarm (libp2p#613) Remove dependency on tokio_current_thread (libp2p#606) Use chashmap from crates (libp2p#615) Fix grammar in core/nodes etc. (libp2p#608) Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592) Add a IdentifyTransport (libp2p#569) Tests for HandledNode (libp2p#546) Some minor fixes reported by clippy (libp2p#600) Add a PeriodicIdentification protocol handler (libp2p#579) Add ProtocolsHandler trait (libp2p#573) Use paritytech/rust-secp256k1 (libp2p#598) Use websocket 0.21.0 (libp2p#597) Reexport multihash from the facade (libp2p#587) Add substrate to the list of projects using libp2p (libp2p#595) Remove spaces before semicolons (libp2p#591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows generating a peer id that starts with a specific prefix.
Useful for generating for example fancy network keys for bootstrap nodes.