Tests for HandledNode #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-listeners * upstream/master: Implement GET_PROVIDERS/ADD_PROVIDER Kademlia messages (libp2p#530) Make secio almost compile for asmjs/wasm (libp2p#519) Make it possible to accept/deny nodes in CollectionsStream (libp2p#512) Fix polling in handled_node.rs (libp2p#531) Remove notifying tasks (libp2p#528) Fix handler not properly shut down, and write test for this (libp2p#514) Use unsigned-varints, add BLAKE2 support in multihash (libp2p#525) Upgrade smallvec version to fix license issue (libp2p#526)
…e-listeners * upstream/master: Add unit tests for core::nodes::NodeStream (libp2p#535)
…e-listeners * upstream/master: Fix secio compied with --no-default-features (libp2p#545) multiaddr: explain the use of `&str` for `Unix`. (libp2p#543) Model HandshakeContext with explicit state transitions. (libp2p#532) multiaddr: add support for onion protocol. (libp2p#542)
TheWaWaR
reviewed
Oct 10, 2018
.gitignore
Outdated
| @@ -1,2 +1,4 @@ | |||
| target | |||
| Cargo.lock | |||
| .idea/** | |||
| CMakeLists.txt | |||
There was a problem hiding this comment.
…andled_node * dp/chore/test-core-listeners: Prefer freestanding function Address grumbles Remove non-project specific stuff Address grumbles
Add HandlerState and use it in TestBuilder Shorter test names
Test NotReady case
Track events as they reach the Handler Describe complex test logic
…e-handled_node * upstream/master: New core (libp2p#568)
…e-handled_node * upstream/master: Fix the polling process in handled node (libp2p#582) Fix panicking when Kad responder is destroyed (libp2p#575) Remove other unused files (libp2p#570) Fix panic in raw swarm (libp2p#571) Remove two unused files (libp2p#567)
…e-handled_node * upstream/master: Remove even more unused files (libp2p#581)
…e-handled_node * upstream/master: Add protocol to report external address view. (libp2p#566) Add a TransportExt trait (libp2p#533) libp2p#399 remove tokio_current_thread tests (libp2p#577)
tomaka
suggested changes
Oct 30, 2018
core/src/tests/dummy_handler.rs
Outdated
| } | ||
| fn inject_event(&mut self, inevent: Self::InEvent) { | ||
| self.events.push(inevent) | ||
| } |
There was a problem hiding this comment.
Indentation.
Also this repo uses spaces and rustfmt.
You can use rustfmt but please only commit this file, otherwise you'll conflict with the entire world.
core/src/nodes/handled_node.rs
Outdated
| // – …and causes the Handler to yield Async::Ready(None) | ||
| // – which in turn makes the HandledNode to yield Async::Ready(None) as well | ||
| assert_matches!(handled.poll(), Ok(Async::Ready(None))); | ||
| assert_eq!(handled.handler.events, vec
|
CI reports a legit parsing error. |
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 2, 2018
…_swarm * upstream/master: Add a IdentifyTransport (libp2p#569) Tests for HandledNode (libp2p#546) Some minor fixes reported by clippy (libp2p#600)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 2, 2018
…e-handled_node_tasks * upstream/master: Add a IdentifyTransport (libp2p#569) Tests for HandledNode (libp2p#546) Some minor fixes reported by clippy (libp2p#600) Add a PeriodicIdentification protocol handler (libp2p#579) Add ProtocolsHandler trait (libp2p#573) Use paritytech/rust-secp256k1 (libp2p#598) Use websocket 0.21.0 (libp2p#597) Reexport multihash from the facade (libp2p#587) Add substrate to the list of projects using libp2p (libp2p#595) Remove spaces before semicolons (libp2p#591)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 9, 2018
…lection_stream * upstream/master: Use vecdeque for fair polling (libp2p#610) Add back the Swarm (libp2p#613) Remove dependency on tokio_current_thread (libp2p#606) Use chashmap from crates (libp2p#615) Fix grammar in core/nodes etc. (libp2p#608) Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592) Add a IdentifyTransport (libp2p#569) Tests for HandledNode (libp2p#546) Some minor fixes reported by clippy (libp2p#600) Add a PeriodicIdentification protocol handler (libp2p#579) Add ProtocolsHandler trait (libp2p#573) Use paritytech/rust-secp256k1 (libp2p#598) Use websocket 0.21.0 (libp2p#597) Reexport multihash from the facade (libp2p#587) Add substrate to the list of projects using libp2p (libp2p#595) Remove spaces before semicolons (libp2p#591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for a review. I have left a ton of debugging
println!in the code as I expect this to need some work before it's ready to merge: I think a few of these tests are very brittle so if someone have ideas on how to do better, please speak up. :)Let me know if you notice any important code paths that are not tested, it's easy to miss some.