Add implementations of NetworkBehaviour for ping #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
twittner
approved these changes
Nov 8, 2018
| } | ||
| } | ||
|
|
||
| impl<TSubstream> NetworkBehavior for PeriodicPingBehaviour<TSubstream> |
There was a problem hiding this comment.
Just noticed that our spelling of behaviour is inconsistent.
There was a problem hiding this comment.
Yeah, I noticed that and want to fix the typo once everything is merged.
dvdplm
reviewed
Nov 9, 2018
protocols/ping/src/dial_layer.rs
Outdated
| use void::Void; | ||
| use PeriodicPingHandler; | ||
|
|
||
| /// Network behaviour that handles receiving to pings sent by other nodes. |
protocols/ping/src/listen_layer.rs
Outdated
| use void::Void; | ||
| use PingListenHandler; | ||
|
|
||
| /// Network behaviour that handles receiving to pings sent by other nodes. |
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 14, 2018
…e-handled_node_tasks * upstream/master: Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 14, 2018
…st-collection_stream * dp/chore/test-core-handled_node_tasks: (24 commits) Revert changes to Debug impl for HandledNodesTasks whitespace Don't organise tests in submodules Rename test builders Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621) Remove tests for Task we don't need Test Task.send_event() and id() using a HandledNodesTasks Better debug impl for HandledNodesTasks Address grumbles ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #596
Trivial layers that just apply a protocol handler to each connection.