Add an IdentifyListen behaviour #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it would be great if the list of supported protocols and the listened addresses were automatic. |
twittner
approved these changes
Nov 12, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 14, 2018
…e-handled_node_tasks * upstream/master: Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 14, 2018
…st-collection_stream * dp/chore/test-core-handled_node_tasks: (24 commits) Revert changes to Debug impl for HandledNodesTasks whitespace Don't organise tests in submodules Rename test builders Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621) Remove tests for Task we don't need Test Task.send_event() and id() using a HandledNodesTasks Better debug impl for HandledNodesTasks Address grumbles ...
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 16, 2018
…_swarm * upstream/master: (33 commits) Behavior -> Behaviour (libp2p#650) Remove Send/Sync/'static reqs from ping (libp2p#652) Tests for CollectionStream (libp2p#588) Document the muxing module (libp2p#647) Document the core::upgrade module (libp2p#644) Send Close when shutting down gracefully, as per spec (libp2p#631) Remove the Send + 'static requirements for floodsub (libp2p#637) Move protocols_handler to the root (libp2p#643) Use a random sequence number in floodsub (libp2p#634) Split `ConnectionUpgrade`. (libp2p#642) Add an impl Debug for HandledNode (libp2p#628) minor typo in docs (libp2p#640) Update connected peers' topics on NodeEvent (libp2p#638) Fix the concerns of libp2p#603 (libp2p#635) Tests for HandledNodesTasks (libp2p#584) Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add it in #579
This is the listening side. You set the information ahead of time, and the behaviour automatically handles requests.