More precise errors in the nodes module #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
twittner
reviewed
Dec 11, 2018
core/src/nodes/collection.rs
Outdated
| @@ -406,6 +409,10 @@ impl<TInEvent, TOutEvent, THandler> CollectionStream<TInEvent, TOutEvent, THandl | |||
| error: err, | |||
| }) | |||
| }, | |||
| (Some(TaskState::Connected(_)), _, _) => { | |||
| // TODO: this variant shouldn't happen; prove this | |||
| panic!() | |||
There was a problem hiding this comment.
Maybe the proof could be added as part of this PR?
twittner
approved these changes
Dec 11, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Dec 19, 2018
* upstream/master: More precise error passed to inject_dial_upgrade_error (libp2p#771) Update muxers to edition 2018 (libp2p#788) it -> this (libp2p#784) Add helpers for easier Transports creation (libp2p#777) Store information about the local node in the topology (libp2p#772) Upgrade secio to the 2018 edition (libp2p#774) Switch ping to edition 2018 (libp2p#780) Remove PeriodicIdentifyListen and IdentifyListen (libp2p#769) Add an IdentifyTopology (libp2p#770) More precise errors in the nodes module (libp2p#765) Simplify handling of upgrade information. (libp2p#761) Add version numbers in the deps in Cargo.toml (libp2p#768) Move the transport timeout to libp2p_core (libp2p#764) multistream-select: Update to 2018 edition. (libp2p#766) Add a mDNS network behaviour (libp2p#736) Remove weird line from readme (libp2p#763) Rename libp2p-tcp-transport to libp2p-tcp (libp2p#762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type Error;associated type toNodeHandler. For now it is always set toio::Errorfor theNodeHandlerWrapper, otherwise this PR would be even bigger. A further PR should make it generic as well.handled_node_taskandcollection.rs, we now properly separate between a reach error (happens when dialing a node or negotiating secio/mplex/yamux) and a node error (happens after we are connected).handled_nodeandraw_swarm::NodeError, we distinguish between an error generated by the muxer and an error generated by the node handler. Eventually theStreamMuxershould also get anErrorassociated type.RawSwarmEvent::DialError, we now return aRawSwarmReachErrorwhich distinguishes between an error produced by the transport layer (including negotiating secio/mplex/yamux) and a mismatch in the peer ID.