Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers for easier Transports creation #777

Merged
merged 3 commits into from
Dec 14, 2018
Merged

Add helpers for easier Transports creation #777

merged 3 commits into from
Dec 14, 2018

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Dec 12, 2018

Fix #735

Also makes CommonTransport private.
I tried to remove CommonTransport in favour of a build_tcp_ws() method, but I got compilation errors.

It would be nice to eventually remove all these Send/Sync requirements, but I'm not sure how.

@ghost ghost assigned tomaka Dec 12, 2018
@ghost ghost added the in progress label Dec 12, 2018
@miketang84
Copy link
Contributor

libp2p::build_development_transport(local_key);

Why use this function name, seems casual.

@tomaka
Copy link
Member Author

tomaka commented Dec 13, 2018

seems casual.

What do you mean by casual?

@miketang84
Copy link
Contributor

seems casual.

What do you mean by casual?

if we have a API named build_development_transport, do we have a product version: build_product_transport?

@tomaka
Copy link
Member Author

tomaka commented Dec 14, 2018

The production version would be build_tcp_ws_secio_mplex_yamux().
The difference is that build_development_transport() will get support for additional new protocols, while others are specific to a specific set of protocols and will not change.

@tomaka
Copy link
Member Author

tomaka commented Dec 14, 2018

I'm going to merge this. Let me know if that's not fine.

@tomaka tomaka merged commit 123cfcd into libp2p:master Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@tomaka tomaka deleted the transport-helpers branch December 14, 2018 09:42
@miketang84
Copy link
Contributor

The production version would be build_tcp_ws_secio_mplex_yamux().
The difference is that build_development_transport() will get support for additional new protocols, while others are specific to a specific set of protocols and will not change.

OK.

jamesray1 pushed a commit to jamesray1/rust-libp2p that referenced this pull request Dec 19, 2018
@tomaka @jamesray1
Add helpers for easier Transports creation (libp2p#777)
16d22b3 
* Add helpers for easier Transports creation

* Fix doctests
dvdplm added a commit to dvdplm/rust-libp2p that referenced this pull request Dec 19, 2018
@dvdplm
Merge remote-tracking branch 'upstream/master' into dp/chore/test_muxer
54f6e15 
* upstream/master:
  More precise error passed to inject_dial_upgrade_error (libp2p#771)
  Update muxers to edition 2018 (libp2p#788)
  it -> this (libp2p#784)
  Add helpers for easier Transports creation (libp2p#777)
  Store information about the local node in the topology (libp2p#772)
  Upgrade secio to the 2018 edition (libp2p#774)
  Switch ping to edition 2018 (libp2p#780)
  Remove PeriodicIdentifyListen and IdentifyListen (libp2p#769)
  Add an IdentifyTopology (libp2p#770)
  More precise errors in the nodes module (libp2p#765)
  Simplify handling of upgrade information. (libp2p#761)
  Add version numbers in the deps in Cargo.toml (libp2p#768)
  Move the transport timeout to libp2p_core (libp2p#764)
  multistream-select: Update to 2018 edition. (libp2p#766)
  Add a mDNS network behaviour (libp2p#736)
  Remove weird line from readme (libp2p#763)
  Rename libp2p-tcp-transport to libp2p-tcp (libp2p#762)
twittner pushed a commit that referenced this pull request Dec 19, 2018
@jamesray1 @twittner
Chore/semi colons (#799)
f541df3 
* Add helpers for easier Transports creation (#777)

* Add helpers for easier Transports creation

* Fix doctests

* Fix ' ;' occurrences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twittner twittner twittner approved these changes

Assignees

@tomaka tomaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaka @miketang84 @twittner