src/lib: Default to WindowUpdateMode::OnRead #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to `WindowUpdateMode::OnRead`, thus enabling full Yamux flow-control, exercising back pressure on senders, preventing stream resets due to reaching the buffer limit. See the [`WindowUpdateMode` documentation] for details, especially the section on deadlocking when sending data larger than the receivers window. [`WindowUpdateMode` documentation]: https://docs.rs/yamux/0.9.0/yamux/enum.WindowUpdateMode.html
AgeManning
approved these changes
Jun 3, 2021
|
//CC @ec2 and @olibearo as you are currently using https://github.com/ChainSafe/forest/blob/main/node/forest_libp2p/src/service.rs#L381 //CC @koivunej for rust-ipfs: https://github.com/rs-ipfs/rust-ipfs/blob/master/src/p2p/transport.rs#L31 //CC @dvc94ch for ipfs-embed: https://github.com/ipfs-rust/ipfs-embed/blob/master/src/net/mod.rs#L93 |
koivunej
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Thanks for the ping @mxinden! Per your explanation this sounds very much a reasonable default but I don't have knowledge on yamux internals except for what I've learned by reading random issues.
|
Seems ok. It's not a breaking change as it only affects the receiver behavior if I understand correctly. Thanks! |
mxinden
added a commit
to mxinden/rust-yamux
that referenced
this pull request
Nov 23, 2023
Continuation of libp2p#120. Preparation for libp2p#175. Also removes dead-lock warning for `WindowUpdateMode::OnRead`. With the restructuring of `Connection::poll`, one reads from the socket when writing is blocked. Thus the deadlock can not occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to
WindowUpdateMode::OnRead, thus enabling full Yamuxflow-control, exercising back pressure on senders, preventing stream
resets due to reaching the buffer limit.
See the
WindowUpdateModedocumentation for details, especially thesection on deadlocking when sending data larger than the receivers
window.
This would prevent surprises like libp2p/rust-libp2p#2089.