chore: deprecate WindowUpdateMode::OnReceive
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of libp2p#120. Preparation for libp2p#175. Also removes dead-lock warning for `WindowUpdateMode::OnRead`. With the restructuring of `Connection::poll`, one reads from the socket when writing is blocked. Thus the deadlock can not occur.
mxinden
commented
Nov 23, 2023
mxinden
added a commit
to mxinden/rust-yamux
that referenced
this pull request
Nov 23, 2023
Follow up to previous deprecation libp2p#177. Fixes libp2p#175.
This was referenced Nov 23, 2023
thomaseizinger
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #120.
Preparation for #175.
Also removes dead-lock warning for
WindowUpdateMode::OnRead. With the restructuring ofConnection::poll, one reads from the socket when writing is blocked. Thus the deadlock can not occur.