Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings/sponsorblock): allow changing sb user id #4749

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

FineFindus
Copy link
Contributor

Adds a setting to change the used SponsorBlock user ID. Users may want to change (or view) it, as SponsorBlock keeps track of the amount of submitted segments.

Setting with SponsorBlock username setting

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bnyro Bnyro merged commit 88334d0 into libre-tube:master Sep 10, 2023
4 checks passed
@FineFindus FineFindus deleted the feat/set-sb-id branch September 10, 2023 14:44
@@ -472,6 +472,7 @@
<string name="segment_type">Segment type</string>
<string name="sb_invalid_segment">Invalid segment start or end</string>
<string name="contribute_to_sponsorblock">Contribute to SponsorBlock</string>
<string name="sponsorblock_user_id">SponsorBlock Username</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usernames are a seperate thing in SponsorBlock, can this be changed to "SponsorBlock UserID"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants