Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings/sponsorblock): allow changing sb user id #4749

Merged
merged 1 commit into from
Sep 10, 2023
Merged

feat(settings/sponsorblock): allow changing sb user id #4749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@
<string name="segment_type">Segment type</string>
<string name="sb_invalid_segment">Invalid segment start or end</string>
<string name="contribute_to_sponsorblock">Contribute to SponsorBlock</string>
<string name="sponsorblock_user_id">SponsorBlock Username</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usernames are a seperate thing in SponsorBlock, can this be changed to "SponsorBlock UserID"?

<string name="filename_too_long">Filename too long!</string>

<!-- Notification channel strings -->
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/xml/sponsorblock_settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
app:key="sb_contribute_key"
app:title="@string/contribute_to_sponsorblock" />

<EditTextPreference
android:dependency="sb_contribute_key"
app:key="sb_user_id"
app:title="@string/sponsorblock_user_id" />

<SwitchPreferenceCompat
app:defaultValue="false"
app:key="dearrow"
Expand Down
Loading