Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared state async insert rate #1105

Open
javierbrk opened this issue May 7, 2024 · 6 comments
Open

Shared state async insert rate #1105

javierbrk opened this issue May 7, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@javierbrk
Copy link
Collaborator

There is a maximum insertion rate into shared state async associated to the update_interval, when you try to insert information before update_interval shared state will fail and wont inform about it.

Successive calls will end up writing.

--minimum renewal for mesh wide was 30s, once written the user hast to wait until ttl is 2400 - 30.

example: this is not writable

    {
        "key": "upgrade_state",
        "value": {
            "mAuthor": "LiMe-1f73aa",
            "mTtl": {
                "xint64": **2376**,
                "xstr64": "**2376**"
            },
            "mData": "NOT_READY"
        }
    }

is writable

        "key": "upgrade_state",
        "value": {
            "mAuthor": "LiMe-1f73aa",
            "mTtl": {
                "xint64": **2367**,
                "xstr64": "**2367**"
            },
            "mData": "NOT_READY"
        }
@ilario
Copy link
Member

ilario commented Nov 7, 2024

Has this been fixed in #1111?

@ilario
Copy link
Member

ilario commented Nov 16, 2024

Also, does this affect the 2024.1 release candidate?

@javierbrk
Copy link
Collaborator Author

Hi ! when using my custom builds from the latest main branch there is no issue. The problem was already addressed and it seems to be incorporated in 2024 branch.

The fix was included in
libremesh/shared-state-async@db58e3d#diff-c8010b427ccbce30ac1e2caa0b136aad8ff4b7fb038ef8e16f9885da868c4358R27

bring to lime-pacakges in
de9ff02

But, I have tested the build for x86 downloaded from https://downloads.libremesh.org/releases/2024.1-rc1-ow23.05.3-default/targets/x86/64/ and indeed there is a problem.

Are the x86 builds outdated ?

@a-gave
Copy link
Contributor

a-gave commented Nov 27, 2024

Are the x86 builds outdated ?

This is very likely. If of any help there is a development build done in September at https://downloads.libremesh.org/development/master-ow23.05.4-527c1eb-20240905-mini/ announced in https://lists.autistici.org/message/20240908.085937.479f1ea2.en.html

@javierbrk
Copy link
Collaborator Author

javierbrk commented Dec 9, 2024 via email

@javierbrk
Copy link
Collaborator Author

I have a script to test if shared-state-async has the fix, I used it to test the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants