add autotools tarball support #13

vtjnash · 2021-07-20T04:45:46Z

This uploads the result of make dist, in addition to the existing files

haampie · 2021-08-23T08:37:29Z

Could someone review this? (@saghul maybe?) libuv is a dependency of cmake, and it seems it's the only thing that pulls in autotools as build dependency, which in turn pulls in perl, and other deps :(

release.js

bnoordhuis · 2021-08-24T09:40:41Z

release.js

+      });
+    });
+  });
+}


Bit of a callback pyramid of doom going on in this function. I don't think there's any harm in using .execFileSync() or async/await.

If you want to stick with the callback style, consider breaking out the steps into separate functions (can be lexically scoped to the outer function.)

AFAICT, execFileSync doesn't support stdio access and async/await would require structural changes that I don't want to do right now. I could Promise-ify the code instead, but that seemed like a significant change also, and seems like it forces us to resolve all of them (so we can't pause part way through the steps, but are forced to finish them, even after failure), but I may not understand Promises that well yet. The problem with separate functions is that it forces the code to go in inverse order, which seemed just as bad as the code pyramid formatting issue.

saghul · 2021-08-24T09:55:48Z

README.md

@@ -6,7 +6,7 @@ Command line utility for creating new releases of libuv.

 1. Make sure you have the most up-to-date version of this tool and the libuv
 branch that will be used to create the release.
-2. Currently, the release tool requires Node.js v0.10.x. You may want to use
+2. Currently, the release tool requires Node.js v12.10.x. You may want to use


Really excited to see this! Are the changes in this PR enough to make it work with Node 12?

I don't really know, but I know it won't work in v0.10.x, since I used an API that is available starting in v12

haampie · 2021-08-24T14:25:26Z

Would this mean that the next release gets tarballs with configure scripts, or can we also add those for old releases?

vtjnash · 2021-08-24T17:54:30Z

I have been considering doing a v1.42.1 release, which simply re-releases the v1.42.0 code after this update.

PR-URL: libuv#13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes: libuv/libuv#1679 PR-URL: libuv#13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

haampie · 2021-09-02T15:07:04Z

is this ready? :D

haampie · 2021-09-14T08:04:15Z

Sorry for coming off impatient, but I'd really like to drop a bunch of dependencies when building libuv (ping @saghul / @bnoordhuis )

bernhardkaindl · 2021-09-27T12:30:09Z

I have been considering doing a v1.42.1 release, which simply re-releases the v1.42.0 code after this update.

@vtjnash, this sounds really great! AFAIC is is ready to be done, or are you waiting for something else?
@saghul and @bnoordhuis approve?

PR-URL: #13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes: libuv/libuv#1679 PR-URL: #13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Notable changes: - Build regression fixes for various platform updates (libuv/libuv#3428, libuv/libuv#3419, libuv/libuv#3423, libuv/libuv#3413, libuv/libuv#3431) - Support for GNU/Hurd (libuv/libuv#3450) - Release tool improvements (libuv/libuv-release-tool#13) - Better performing rw locks on Win32 (libuv/libuv#3383) - Support for posix_spawn API (libuv/libuv#3257) - Fixed regression on OpenBSD (libuv/libuv#3506) - Added uv_available_parallelism() (libuv/libuv#3499) - Other bug fixes (libuv/libuv#3524, libuv/libuv#3521) Fixes: nodejs#42290

Notable changes: - Build regression fixes for various platform updates (libuv/libuv#3428, libuv/libuv#3419, libuv/libuv#3423, libuv/libuv#3413, libuv/libuv#3431) - Support for GNU/Hurd (libuv/libuv#3450) - Release tool improvements (libuv/libuv-release-tool#13) - Better performing rw locks on Win32 (libuv/libuv#3383) - Support for posix_spawn API (libuv/libuv#3257) - Fix regression on OpenBSD (libuv/libuv#3506) - Add uv_available_parallelism() (libuv/libuv#3499) - Don't use thread-unsafe strtok() (libuv/libuv#3524) - Fix hang after NOTE_EXIT (libuv/libuv#3521) - Better align order-of-events behavior between platforms (libuv/libuv#3598) - Fix fs event not fired if the watched file is moved/removed/recreated (libuv/libuv#3540) - Fix pipe resource leak if closed during connect (and other bugs) (libuv/libuv#3611) - Don't error when killing a zombie process (libuv/libuv#3625) - Avoid posix_spawnp() cwd bug (libuv/libuv#3597) - Skip EVFILT_PROC events when invalidating events for an fd (libuv/libuv#3629) Fixes: nodejs#42290

Notable changes: - Build regression fixes for various platform updates (libuv/libuv#3428, libuv/libuv#3419, libuv/libuv#3423, libuv/libuv#3413, libuv/libuv#3431) - Support for GNU/Hurd (libuv/libuv#3450) - Release tool improvements (libuv/libuv-release-tool#13) - Better performing rw locks on Win32 (libuv/libuv#3383) - Support for posix_spawn API (libuv/libuv#3257) - Fix regression on OpenBSD (libuv/libuv#3506) - Add uv_available_parallelism() (libuv/libuv#3499) - Don't use thread-unsafe strtok() (libuv/libuv#3524) - Fix hang after NOTE_EXIT (libuv/libuv#3521) - Better align order-of-events behavior between platforms (libuv/libuv#3598) - Fix fs event not fired if the watched file is moved/removed/recreated (libuv/libuv#3540) - Fix pipe resource leak if closed during connect (and other bugs) (libuv/libuv#3611) - Don't error when killing a zombie process (libuv/libuv#3625) - Avoid posix_spawnp() cwd bug (libuv/libuv#3597) - Skip EVFILT_PROC events when invalidating events for an fd (libuv/libuv#3629) Fixes: #42290 PR-URL: #42340 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: - Build regression fixes for various platform updates (libuv/libuv#3428, libuv/libuv#3419, libuv/libuv#3423, libuv/libuv#3413, libuv/libuv#3431) - Support for GNU/Hurd (libuv/libuv#3450) - Release tool improvements (libuv/libuv-release-tool#13) - Better performing rw locks on Win32 (libuv/libuv#3383) - Support for posix_spawn API (libuv/libuv#3257) - Fix regression on OpenBSD (libuv/libuv#3506) - Add uv_available_parallelism() (libuv/libuv#3499) - Don't use thread-unsafe strtok() (libuv/libuv#3524) - Fix hang after NOTE_EXIT (libuv/libuv#3521) - Better align order-of-events behavior between platforms (libuv/libuv#3598) - Fix fs event not fired if the watched file is moved/removed/recreated (libuv/libuv#3540) - Fix pipe resource leak if closed during connect (and other bugs) (libuv/libuv#3611) - Don't error when killing a zombie process (libuv/libuv#3625) - Avoid posix_spawnp() cwd bug (libuv/libuv#3597) - Skip EVFILT_PROC events when invalidating events for an fd (libuv/libuv#3629) Fixes: nodejs#42290 PR-URL: nodejs#42340 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: - Build regression fixes for various platform updates (libuv/libuv#3428, libuv/libuv#3419, libuv/libuv#3423, libuv/libuv#3413, libuv/libuv#3431) - Support for GNU/Hurd (libuv/libuv#3450) - Release tool improvements (libuv/libuv-release-tool#13) - Better performing rw locks on Win32 (libuv/libuv#3383) - Support for posix_spawn API (libuv/libuv#3257) - Fix regression on OpenBSD (libuv/libuv#3506) - Add uv_available_parallelism() (libuv/libuv#3499) - Don't use thread-unsafe strtok() (libuv/libuv#3524) - Fix hang after NOTE_EXIT (libuv/libuv#3521) - Better align order-of-events behavior between platforms (libuv/libuv#3598) - Fix fs event not fired if the watched file is moved/removed/recreated (libuv/libuv#3540) - Fix pipe resource leak if closed during connect (and other bugs) (libuv/libuv#3611) - Don't error when killing a zombie process (libuv/libuv#3625) - Avoid posix_spawnp() cwd bug (libuv/libuv#3597) - Skip EVFILT_PROC events when invalidating events for an fd (libuv/libuv#3629) Fixes: #42290 PR-URL: #42340 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

haampie mentioned this pull request Aug 23, 2021

cmake~ownlibs does not depend on openssl spack/spack#25559

Merged

bnoordhuis approved these changes Aug 24, 2021

View reviewed changes

saghul reviewed Aug 24, 2021

View reviewed changes

vtjnash added a commit to vtjnash/libuv-release-tool that referenced this pull request Aug 24, 2021

fix off-by-one error in release day

656ea63

PR-URL: libuv#13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

vtjnash added a commit to vtjnash/libuv-release-tool that referenced this pull request Aug 24, 2021

add autotools tarball support

4abd4c0

Fixes: libuv/libuv#1679 PR-URL: libuv#13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

vtjnash force-pushed the jn/autotools-dist branch 2 times, most recently from 27f0f91 to 68f1f76 Compare August 24, 2021 18:37

vtjnash mentioned this pull request Jan 4, 2022

Release proposal: v1.43.0 libuv/libuv#3397

Closed

vtjnash mentioned this pull request Feb 1, 2022

Release proposal: v1.44.0 libuv/libuv#3452

Closed

8 tasks

vtjnash added a commit that referenced this pull request Mar 2, 2022

fix off-by-one error in release day

da4b362

PR-URL: #13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

vtjnash added a commit that referenced this pull request Mar 2, 2022

add autotools tarball support

860e5b6

Fixes: libuv/libuv#1679 PR-URL: #13 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

vtjnash closed this Mar 2, 2022

vtjnash reopened this Mar 2, 2022

vtjnash closed this Mar 2, 2022

vtjnash force-pushed the jn/autotools-dist branch from 68f1f76 to 860e5b6 Compare March 2, 2022 20:21

vtjnash deleted the jn/autotools-dist branch March 2, 2022 20:21

lpinca mentioned this pull request Mar 15, 2022

deps: upgrade to libuv 1.44.2 nodejs/node#42340

Closed

XVilka mentioned this pull request May 29, 2022

Update default libuv from 1.40.0 to 1.44.1 rizinorg/rizin#2644

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add autotools tarball support #13

add autotools tarball support #13

vtjnash commented Jul 20, 2021

haampie commented Aug 23, 2021

bnoordhuis Aug 24, 2021

vtjnash Aug 24, 2021 •

edited

Loading

saghul Aug 24, 2021

vtjnash Aug 24, 2021

haampie commented Aug 24, 2021

vtjnash commented Aug 24, 2021

haampie commented Sep 2, 2021

haampie commented Sep 14, 2021 •

edited

Loading

bernhardkaindl commented Sep 27, 2021 •

edited

Loading

add autotools tarball support #13

add autotools tarball support #13

Conversation

vtjnash commented Jul 20, 2021

haampie commented Aug 23, 2021

bnoordhuis Aug 24, 2021

Choose a reason for hiding this comment

vtjnash Aug 24, 2021 • edited Loading

Choose a reason for hiding this comment

saghul Aug 24, 2021

Choose a reason for hiding this comment

vtjnash Aug 24, 2021

Choose a reason for hiding this comment

haampie commented Aug 24, 2021

vtjnash commented Aug 24, 2021

haampie commented Sep 2, 2021

haampie commented Sep 14, 2021 • edited Loading

bernhardkaindl commented Sep 27, 2021 • edited Loading

vtjnash Aug 24, 2021 •

edited

Loading

haampie commented Sep 14, 2021 •

edited

Loading

bernhardkaindl commented Sep 27, 2021 •

edited

Loading