refactor node-demos to utilize a filesystem module #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've currently checked in the node_modules folder in `demos/nodejs` as
it is only a symbolic link to the root of the repo. I'm unsure if this
is supported cross platform, specifically windows.
The advantage here is that the demo scripts now require("flocking"),
which is much nicer to copy paste 🎉
|
The Node.js demos have been removed from Flocking with #258, so this PR is now no longer needed. Thanks for the fix, @MylesBorins! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've currently checked in the node_modules folder in
demos/nodejsasit is only a symbolic link to the root of the repo. I'm unsure if this
is supported cross platform, specifically windows.
The advantage here is that the demo scripts now require("flocking"),
which is much nicer to copy paste 🎉