Resolves gh-253: Removes Node.js support from Flocking #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Fixes gh-252: Regularizes synth evaluation. Removes pseudo-modelism. Removes remaining uses of .input(); renames Synth.gen to generate. gh-252: Updates tests for synth restructuring and removal of input(). Renames Synth.genFn to generate(). gh-252: Moves synth-related grades into separate files.
This was referenced Dec 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a lack of reliability and support in Flocking's core Node.js audio output and MIDI libraries, and a lack of strong alternatives, this pull request removes "native" support for Node.js from Flocking. Developers can still create Flocking applications that take advantage of Node-based APIs and modules using Electron or newer tools such as Puppeteer or Carlo, and further work on this kind of an approach is covered in #257.