-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates PyMC requirement #19
Conversation
fixes code to configure pymc's/pytensor's default float type
@hriebl, this PR bumps the jax, jaxlib requirements to 0.4.1. |
I think it would be nice to make a minor release quite soon, once this PR is merged. Otherwise, the liesel installation from pypi is broken. |
@jobrachem, why is it currently broken? |
There's an import error because of (I think) the new Jax version that gets installed alongside Liesel in a fresh venv. Will test this again and post the full error message in the morning, am currently only on the phone. |
Hmm, I don't seem to get any import errors on my system. The fact that the tests fail for 9ea3700 seems to be unrelated to this specific commit or PR. It might have something to do with the new NumPy release 1.24 ( Could any of you investigate this further? |
I cannot reproduce the issue that I had yesterday in a fresh virtualenv today. Yesterday, I was on an existing virtualenv and my steps, as I recall them, were
But since I cannot reproduce the issue today, I can only conclude that my message was premature. |
This is indeed the same error as the one we had in https://github.com/liesel-devs/liesel-internal/issues/200#issuecomment-1358816001. I cannot pin down the issue so far though. The data types in the plot_df columns don't look too suspicious to me:
|
Thank you for pointing me to that issue! I had missed it while in Florence. |
I think I found the reason for the failing tests on this PR: |
I followed mwaskom/seaborn#3194 and marked NumPy 1.24.0 as incompatible in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the tests are working, I'm happy with this PR. Should we go ahead and merge?
Set's pymc requirement to >= 5.0.0.
Also, fixes code to configure pymc's/pytensor's default float type to follow PyMC's change of the dependency from aesera to pytensor which is a fork of aesera.