Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark numpy 1.24.0 as non-compatible #3194

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Mark numpy 1.24.0 as non-compatible #3194

merged 1 commit into from
Dec 19, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Dec 19, 2022

A bug in numpy 1.24.0 hard-breaks a number of seaborn functions: numpy/numpy#22826

Marking the whole release as non-compatible to avoid trouble.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #3194 (4f431ad) into master (9bd1665) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3194   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          76       76           
  Lines       24110    24110           
=======================================
  Hits        23729    23729           
  Misses        381      381           

@mwaskom mwaskom merged commit 26b3d0e into master Dec 19, 2022
@mwaskom mwaskom deleted the deps/np_124 branch December 19, 2022 23:58
MorrisNein added a commit to aimclub/FEDOT that referenced this pull request Dec 20, 2022
According to this PR, Seaborn is not compatible with NumPy due to the bug in the last:

mwaskom/seaborn#3194

Thus, restricting the bugged NumPy version only.
MorrisNein added a commit to aimclub/FEDOT that referenced this pull request Dec 20, 2022
According to this PR, Seaborn is not compatible with NumPy 1.24.0 due to a bug in the latter:

mwaskom/seaborn#3194

Furthermore, the bug is going to be fixed by numpy 1.24.1:

https://github.com/numpy/numpy/milestone/114

Thus, restricting the bugged NumPy version only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant