-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization - Support for Spanish Localization #239
Comments
I'm working on this now, should be done within the next week. |
Thanks for letting me know, and nice to see that the add-on will get another translation. If there is something unclear with the strings, don't hesitate to ask. Note that on https://www.babelzilla.org someone named strel started a Spanish translation a while back, but never finished it. Attached is what he translated. Note that it is still in the old format Please let me know if you integrate his work instead of just starting from scratch, so that he will get attributed in that case. |
Ok thanks for the additional legacy work file reference, i'll cross-reference/review it when defining the new ES translations. but likely will not use it directly (of course some strings will be identical). looks like Strel got about 40% though the message list. |
2021_02_19 50% complete.. ETA 1 week more |
Task completed, ready to commit to master. Tested on local env - all good. How should I do the commit as commit access permission is locked? |
Nice to hear you are finished, and sorry for the late reply. GitHub works mainly with pull request for collaboration. You need to:
Note that |
This reverts commit eb21500.
Grand, i had already forked the project last year, and was working off of that. I just committed and added a pull request above. Actually had to revert out all unrelated stuff that i'm playing with regarding load testing of DNSServer queries and intermittent timeouts to narrow the pull to related files for ES localization. What's next on the development pipeline, happy to help out, just id issues that need review. |
Will leave this open as a reminder to upload the Spanish descriptions to ATN.
I'm in the process of moving the last missing pieces from the 3.x Version to the 4.x Version. Afterwards the short term plan is in https://github.com/lieser/dkim_verifier/milestone/16.
It is a little unclear to me, are you offering to review changes I do, or are you interested in doing some development work yourself? If more people start to contribute, I also think this repo should get some CI, instead of me running the tools (unit tests, eslint, type checking) just locally. |
Translation is added to ATN: https://addons.thunderbird.net/es/thunderbird/addon/dkim-verifier/ |
Add support for Spanish Localization, and subfolder for ES-es under _locales.
Using European Castilian Spanish
The text was updated successfully, but these errors were encountered: