Merge pull request #212 from lifeomic/update-semantic-release-tooling

fix: Add feedback for semantic-release
lifeomic · Apr 6, 2022 · 918498b · 918498b
2 parents f3540de + 0c8edf9
commit 918498b
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 6 deletions.
diff --git a/.github/lifeomic-probot.yml b/.github/lifeomic-probot.yml
@@ -0,0 +1 @@
+enforceSemanticCommits: true
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ jobs:
  environment: npm
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- NPM_TOKEN: ${{secrets.LIFEOMIC_NPM_TOKEN}}
+ NPM_TOKEN: ${{ secrets.LIFEOMIC_NPM_TOKEN }}
  steps:
  - uses: actions/checkout@v2
  - uses: actions/setup-node@v1
@@ -20,6 +20,7 @@ jobs:
  registry-url: https://registry.npmjs.org
  - name: Build and Test
  run: |
+ echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc
  yarn install
  yarn test
  yarn build

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@lifeomic/cli",
- "version": "13.6.0",
+ "version": "0.0.0",
  "description": "CLI for interacting with the LifeOmic PHC API.",
  "main": "lo.js",
  "author": "LifeOmic <development@lifeomic.com>",
@@ -17,8 +17,7 @@
  "lint": "eslint .",
  "pretest": "yarn lint",
  "test": "ava --serial --verbose test/unit",
- "build": "./build.sh",
- "semantic-release": "semantic-release"
+ "build": "./build.sh"
  },
  "dependencies": {
  "axios": "^0.21.1",
@@ -54,12 +53,13 @@
  "@lifeomic/eslint-plugin-node": "^1.3.0",
  "ava": "^0.25.0",
  "axios-mock-adapter": "^1.19.0",
+ "conventional-changelog-conventionalcommits": "^4.6.3",
  "eslint": "^4.19.1",
  "memory-streams": "^0.1.3",
  "pkg": "^4.4.3",
  "proxyquire": "^2.1.0",
- "sinon": "^4.5.0",
- "semantic-release": "^19.0.2"
+ "semantic-release": "^19.0.2",
+ "sinon": "^4.5.0"
  },
  "eslintConfig": {
  "extends": "plugin:@lifeomic/node/recommended"

diff --git a/release.config.js b/release.config.js
@@ -1,6 +1,7 @@
 module.exports = {
  branches: ['master'],
  plugins: [
+ ['@semantic-release/commit-analyzer', { preset: 'conventionalcommits' }],
  '@semantic-release/npm',
  [
  '@semantic-release/github',

diff --git a/yarn.lock b/yarn.lock
@@ -2031,6 +2031,15 @@ conventional-changelog-angular@^5.0.0:
  compare-func "^2.0.0"
  q "^1.5.1"
 
+conventional-changelog-conventionalcommits@^4.6.3:
+ version "4.6.3"
+ resolved "https://registry.yarnpkg.com/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-4.6.3.tgz#0765490f56424b46f6cb4db9135902d6e5a36dc2"
+ integrity sha512-LTTQV4fwOM4oLPad317V/QNQ1FY4Hju5qeBIM1uTHbrnCE+Eg4CdRZ3gO2pUeR+tzWdp80M2j3qFFEDWVqOV4g==
+ dependencies:
+ compare-func "^2.0.0"
+ lodash "^4.17.15"
+ q "^1.5.1"
+
 conventional-changelog-writer@^5.0.0:
  version "5.0.1"
  resolved "https://registry.yarnpkg.com/conventional-changelog-writer/-/conventional-changelog-writer-5.0.1.tgz#e0757072f045fe03d91da6343c843029e702f359"