fix: Add feedback for semantic-release #212
Conversation
Do this to align with LO standard implementation
| @@ -20,6 +20,7 @@ jobs: | |||
| registry-url: https://registry.npmjs.org | |||
| - name: Build and Test | |||
| run: | | |||
| echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc | |||
There was a problem hiding this comment.
Last build failed - based on the docs, I thought semantic-release would pick up the token from the environment variable, but I'm adding this to see if it picks it up from there
There was a problem hiding this comment.
And I did confirm that this repo is configured for the npm environment in repo-standard, so this token should be available
There was a problem hiding this comment.
Nice change. If the setup-node action sets an .npmrc file (seems possible), then it will override our token.
I actually tried to fix the semantic-release docs around this a while back 😂, because they were wrong. Even with my fix, they're still not great :/
| @@ -20,6 +20,7 @@ jobs: | |||
| registry-url: https://registry.npmjs.org | |||
| - name: Build and Test | |||
| run: | | |||
| echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc | |||
There was a problem hiding this comment.
Nice change. If the setup-node action sets an .npmrc file (seems possible), then it will override our token.
I actually tried to fix the semantic-release docs around this a while back 😂, because they were wrong. Even with my fix, they're still not great :/
|
🎉 This PR is included in version 13.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Requested review from a random This review is not blocking and is for broader awareness. Consider if this change requires deeper security review and ask when it is necessary. |
Do this to align with LO standard implementation