LPD-45051 - Row actions are disappearing in Clay Table FDS when hiding a column. #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at are currently visible.
… of the column when all columns are visible.
…he ClayTable calculate visibleColumns after that.
|
CI is automatically triggering the following test suites:
|
|
ci:test:sf |
|
ci:test:relevant |
|
FYI @markocikos |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-45051 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#4002 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4645 Testray Routine:EE Pull Request Testray Build ID:105168358 Testray Importer:publish-testray-report#15759 |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - success
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 22 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-45051 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6061 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4645 Testray Routine:EE Pull Request Testray Build ID:105171174 Testray Importer:publish-testray-report#24055 |
✔️ ci:test:stable - 24 out of 24 jobs passed✔️ ci:test:relevant - 29 out of 29 jobs passed in 1 hour 4 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 83a242f48ab4b2086965005a590a95e42e9c0a13 ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:
ci:test:relevant - 29 out of 29 jobs PASSED29 Successful Jobs:
For more details click here.Test bundle downloads: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#13538 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4645 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - ethib137 > liferay-frontend - PR#4645 - 2025-01-08[05:08:15] Testray Build ID:105172632 Testray Importer:publish-testray-report#29523 |
|
Will do. Thanks @markocikos ! |
|
Resent at: #4654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-45051
The FDS implementation of the ClayTable was not properly handling row items or visibleColumns. This fixes those issues. The commits explain how.
cc: @matuzalemsteles