Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-38845 Remove Feature Flag for Clay Table in the Frontend Data Set #4654

Closed
wants to merge 25 commits into from
Closed

LPD-38845 Remove Feature Flag for Clay Table in the Frontend Data Set #4654

wants to merge 25 commits into from

Conversation

ethib137
Copy link

@ethib137 ethib137 commented Jan 13, 2025 •
edited by markocikos
Loading

References

Parent Task: LPD-22025 Remove Feature Flag for Clay Table in the Frontend Data Set

What is the goal of this PR?

FF removal, code update, unused code cleanup, update of tests.

Also includes https://liferay.atlassian.net/browse/LPD-45051

The FDS implementation of the ClayTable was not properly handling row items or visibleColumns. This fixes those issues. The commits explain how.

cc @markocikos

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

This was referenced Jan 13, 2025
Closed
Closed
@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b851d80b985bb65db8d131bd7f2c5ed8cbf06231

Sender Branch:

Branch Name: LPD-38845
Branch GIT ID: 07c3bda66d49d28ea3595bb86c16904311a349d9

0 out of 1jobs PASSED
For more details click here.
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] ✅ Checked apps/frontend-data-set/frontend-data-set-web
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec] 
     [exec] Done in 15.92s.
     [exec] 
     [exec] > Task :portalYarnCheckFormat
     [exec] Gradle build finished at 2025-01-13 09:45:39.860.
     [exec] 
     [exec] BUILD SUCCESSFUL in 24s
     [exec] 3 actionable tasks: 3 executed
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-01-13-01-45-18.html
     [exec] A fine-grained performance profile is available: use the --scan option.
[beanshell] Executing Gradle task: packageRunCheckFormat
     [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
     [exec] Daemon will be stopped at the end of the build 
     [exec] > Task :downloadNode
     [exec] 
     [exec] > Task :npmInstall
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] added 130 packages, and audited 134 packages in 1s
     [exec] 
     [exec] 23 packages are looking for funding
     [exec]   run `npm fund` for details
     [exec] 
     [exec] found 0 vulnerabilities
     [exec] 
     [exec] > Task :packageRunCheckFormat
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] > @liferay/playwright@1.0.0 checkFormat
     [exec] > tsc
     [exec] 
     [exec] tests/document-library-web/fileEntry.spec.ts(35,3): error TS2322: Type 'boolean' is not assignable to type 'FeatureFlagValue'.
     [exec] tests/document-library-web/fileEntry.spec.ts(36,3): error TS2322: Type 'boolean' is not assignable to type 'FeatureFlagValue'.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] 
     [exec] Gradle build finished at 2025-01-13 09:46:07.890.
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:107094629

@markocikos
Copy link
Collaborator

ci:test:playwright

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:playwright - 83 out of 116 jobs passed in 2 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b851d80b985bb65db8d131bd7f2c5ed8cbf06231

Upstream Comparison:

Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f
Jenkins Build URL: EE Development Acceptance (master) - 1118 - 2025-01-08[10:16:50]

ci:test:playwright - 83 out of 116 jobs PASSED

33 Failed Jobs:

83 Successful Jobs:
    For more details click here.

    Failures unique to this pull:

    1. playwright-js-tomcat90-mysql57/29/0 - Playwright Report
      1. commerce/commerce-theme-minium/commerceSearch.spec.ts
      2. commerce/commerce-theme-minium/commerceResponsiveUserNav.spec.ts
    6. ...
    Test bundle downloads:

    @liferay-continuous-integration
    Copy link
    Collaborator

    @markocikos
    Copy link
    Collaborator

    ci:report:107229400

    @liferay-continuous-integration
    Copy link
    Collaborator

    Build completed.

    Testray CSV has been generated successfully for testrayBuildID: 107229400.

    Job Link: generate-testray-csv

    Testray CSV Link: testray-results-107229400.csv

    @markocikos
    Copy link
    Collaborator

    markocikos commented Jan 13, 2025 •
    edited
    Loading

    @gianmarcobrunialti 8 commerce failures in last sweep, compared to 11 in previous one. Were you able to confirm if they are related?

    @gianmarcobrunialti
    Copy link

    Hey @markocikos I'll have another run on our commerce-functional suite here as it'll run over night,
    we have many Poshi tests relying on Data Sets and right now we have quite a bit of test-noise on our end as well.

    @gianmarcobrunialti
    Copy link

    ci:test:commerce-functional

    @liferay-continuous-integration
    Copy link
    Collaborator

    ❌ ci:test:commerce-functional - 13 out of 200 jobs passed in 2 hours 27 minutes

    Click here for more details.

    This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

    ci:reevaluate:1387401_11760

    Base Branch:

    Branch Name: master
    Branch GIT ID: b90e8c54bf3e7b4c0596bfda9c2a876c3e57da75

    Upstream Comparison:

    Branch GIT ID: 61b58512ab7f586f7ca6824d9a013acf90aafc3f
    Jenkins Build URL: EE Development Acceptance (master) - 1118 - 2025-01-08[10:16:50]

    ci:test:commerce-functional - 13 out of 200 jobs PASSED

    187 Failed Jobs:

    13 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. source-format-current-branch/0/0
        clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
     [echo] run.batch.test.setup.start.timestamp: 01-13-2025 10:56:34:777 PST
[stopwatch] [run.batch.test.setup: 0.001 sec]
     [echo] run.batch.test.action.start.timestamp: 01-13-2025 10:56:34:779 PST
[stopwatch] [run.batch.test.action: 0.064 sec]
     [echo] exec returned: 128
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null738727493.properties
        1. com.liferay.jenkins.JenkinsLogAsserterTest
      6. ...

      For upstream results, click here.

      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @ethib137
      Copy link
      Author

      ci:report:107521090

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 24 out of 24 jobs passed

      ❌ ci:test:relevant - 31 out of 33 jobs passed in 1 hour 9 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: edc5cb0af36a6c7a7856d7e9e8762f5d754e44b4

      Upstream Comparison:

      Branch GIT ID: d55e3bcb670a60a349ec8f735ea9f4a370dcd598
      Jenkins Build URL: EE Development Acceptance (master) - 1132 - 2025-01-20[12:38:13]

      ci:test:stable - 24 out of 24 jobs PASSED
      24 Successful Jobs:
        ci:test:relevant - 31 out of 33 jobs PASSED

        2 Failed Jobs:

        31 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          For upstream results, click here.

          Test bundle downloads:

          @liferay-continuous-integration
          Copy link
          Collaborator

          @liferay-continuous-integration
          Copy link
          Collaborator

          ❌ ci:test:object - 228 out of 280 jobs passed in 2 hours 28 minutes

          Click here for more details.

          This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

          ci:reevaluate:1307401_10789

          Base Branch:

          Branch Name: master
          Branch GIT ID: edc5cb0af36a6c7a7856d7e9e8762f5d754e44b4

          Upstream Comparison:

          Branch GIT ID: ea06c5ae3f72d20478bffa4a022e971a0ca60b8b
          Jenkins Build URL: EE Development Acceptance (master) - 1133 - 2025-01-20[20:37:55]

          ci:test:object - 228 out of 280 jobs PASSED

          52 Failed Jobs:

          228 Successful Jobs:
            For more details click here.

            Failures unique to this pull:

            6. ...
            Test bundle downloads:

            @liferay-continuous-integration
            Copy link
            Collaborator

            @markocikos
            Copy link
            Collaborator

            ci:report:114060911

            @liferay-continuous-integration
            Copy link
            Collaborator

            Build completed.

            Testray CSV has been generated successfully for testrayBuildID: 114060911.

            Job Link: generate-testray-csv

            Testray CSV Link: testray-results-114060911.csv

            @markocikos
            Copy link
            Collaborator

            ci:report:114139316

            @liferay-continuous-integration
            Copy link
            Collaborator

            Build completed.

            Testray CSV has been generated successfully for testrayBuildID: 114139316.

            Job Link: generate-testray-csv

            Testray CSV Link: testray-results-114139316.csv

            @markocikos
            Copy link
            Collaborator

            No unique failures in relevant, based on #4654 (comment)

            @marcelabc There a quite a few poshi failures in objects, based on #4654 (comment). Almost all are are the same error, Element is not present at "xpath=(//input[(@placeholder='Input a value or create an expression.')]). Are these related to PR?

            @ethib137 I think the cut for release has been done, but I'm not 100% sure. As far as I'm concerned, and if it's ok with @marcelabc, we can force push this.

            @ethib137
            Copy link
            Author

            Hey @markocikos Yes! I think we need to force push this. Based on this the release has been cut and there is now a new release branch. As a result, these changes won't be included until the next release. So let's do it. Let's force push!

            @markocikos
            Copy link
            Collaborator

            Looks like @marcelabc is on medical leave. The failures in objects look unrelated to me, and we already did a round of manual checks. Even if they are related regression, we can fix them in a followup.

            @markocikos
            Copy link
            Collaborator

            @markocikos
            Copy link
            Collaborator

            ci:forward:force

            @liferay-continuous-integration
            Copy link
            Collaborator

            CI is automatically triggering the following test suites:

            •     ci:test:relevant
            •     ci:test:sf
            •     ci:test:stable

            The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

            •     ci:test:relevant
            •     ci:test:sf
              AND If the following test suites pass:
            •     ci:test:stable

            @liferay-continuous-integration
            Copy link
            Collaborator

            Skipping previously completed test suites:

            • ci:test:relevant
            • ci:test:sf
              AND Skipping previously passed test suites:
            • ci:test:stable

            @liferay-continuous-integration
            Copy link
            Collaborator

            All required test suite(s) completed.
            Forwarding pull request to brianchandotcom.
            Console

            Closed
            @liferay-continuous-integration
            Copy link
            Collaborator

            Pull request has been successfully forwarded to brianchandotcom#157937
            Console

            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
            Reviewers

            @liferay-frontend liferay-frontend Awaiting requested review from liferay-frontend liferay-frontend is a code owner

            Assignees
            No one assigned
            Labels
            ci:forward:force ci:test - success ci:test:commerce-functional - failure ci:test:object - failure ci:test:playwright - failure ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
            Projects
            None yet
            Milestone
            No milestone
            Development

            Successfully merging this pull request may close these issues.
            6 participants
            @ethib137 @liferay-continuous-integration @markocikos @gianmarcobrunialti @marcelabc @larissacribeiro