Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liferay Bundler/Babel doesn't understand the spread-operator #565

Closed
2 of 6 tasks
faragos opened this issue Jun 2, 2021 · 3 comments Β· Fixed by #569
Closed
2 of 6 tasks

Liferay Bundler/Babel doesn't understand the spread-operator #565

faragos opened this issue Jun 2, 2021 · 3 comments Β· Fixed by #569

Comments

@faragos
Copy link

faragos commented Jun 2, 2021

πŸ‘€ Please check the troubleshooting guide before reporting anything. It contains important information on how to fix or diagnose errors.

Issue type (mark with x)

  • πŸ€” Question
  • πŸ› Bug report
  • 🎁 Feature request
  • πŸ€·β€β™€οΈ Other

Version (mark with x)

  • 2️⃣ v2.x
  • 3️⃣ v3.x

Description

I'm trying to use Recoil for State-management. Now recoil uses the spread operator and babel fails then when it tries to add the Liferay.bundler.define around it, because it doesn't know the token.

Desired behavior:
The liferay-bundler can parse files with the spread-operator

Current behavior:
The liferay-bundler ignores these files

Repro instructions (if applicable):

  1. install recoil
  2. import it
  3. build it
  4. check the builded files. there should be no Liferay.Loader.define around it.

Other information (environment, versions etc):
Liferay 7.3.6
es6-fail

Maybe there are more ES6 features that would also be nice that babel understands it, but at the moment I think the spread-operator is the important one.

@izaera
Copy link
Member

izaera commented Jun 4, 2021

That fixes it ☝️

@izaera
Copy link
Member

izaera commented Jun 4, 2021

We will try to release a new version with this fix next week.

@izaera
Copy link
Member

izaera commented Jun 7, 2021

This should be fixed in version 2.25.0 of the toolkit (already released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants