fix(js-toolkit): support spread operator when bundling modules #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Are there any other common syntaxes in modern browsers that we might want to add support for? I didn't realize some popular packages like this were starting to not transpile spread operators. |
|
🤔 Not sure. Probably fat arrow... In general, AST parsers are lenient with most of the new features because they fit in the older syntax scheme, but some newer things that are not backward compatible (like this one) may make it fail. I will investigate fat arrow too 👍 |
|
Fat arrow works, so going to merge because I cannot think of any other risky construct now 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
Tested locally with the same project I used to reproduce it (an empty shared bundle with just
recoildependency)