Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate fully to protov2 #436

Merged
merged 12 commits into from
Jan 20, 2022
Merged

feat: Migrate fully to protov2 #436

merged 12 commits into from
Jan 20, 2022

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Jan 18, 2022 •
edited
Loading

This PR contains following changes:

  • migrating from github.com/golang/protobuf to google.golang.org/protobuf (v1.27.1)
  • add required option go_package to .proto files
  • regenerate all protobuf files
  • update dependencies with vulnerabilities reported
  • change durations in configs from nanoseconds to humanized form
  • update etcd to v3.5.1, dropping previously required replace for etcd and grpc

@ondrej-fabry
Update etcd dependency
fc38c3c 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Add StandardLogger to logrus.Logger
622a010 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Migrate to new protobuf
67896b0 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Remove
75058af 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update consul
70d720d 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update jwt-go
6bd67b0 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Fix tests
a6be673 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Remove dependency on github.com/golang/proto
05747d9 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry changed the title Migrate fully to protov2 deps: Migrate fully to protov2 Jan 19, 2022
@ondrej-fabry ondrej-fabry changed the title deps: Migrate fully to protov2 feat: Migrate fully to protov2 Jan 19, 2022
@ondrej-fabry ondrej-fabry mentioned this pull request Jan 19, 2022
Merged
@ondrej-fabry
Fix and enable skipped tests
76ccf3a 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Embed Unimplemented server
18e8734 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update etcd to v3.5.1
eb5a9ac 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update durations in configs to humanized form
fab55b0 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry merged commit 049260a into master Jan 20, 2022
@ondrej-fabry ondrej-fabry deleted the proto2 branch January 20, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgschwan fgschwan fgschwan approved these changes

@VladoLavor VladoLavor VladoLavor approved these changes

Assignees
No one assigned
Labels
🔗 deps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ondrej-fabry @VladoLavor @fgschwan