Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate fully to protov2 #1833

Merged
merged 12 commits into from
Jan 26, 2022
Merged

feat: Migrate fully to protov2 #1833

merged 12 commits into from
Jan 26, 2022

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Jan 19, 2022 •
edited
Loading

This PR contains following changes:

  • migrating from github.com/golang/protobuf to google.golang.org/protobuf (v1.27.1)
  • regenerate all protobuf files
  • update dependencies with vulnerabilities reported
  • update cn-infra
  • instantiate gomega handler for each test context
  • fix some test issues
  • add timeout to agentctl
  • drop previously needed replaces in go.mod for grpc and etcd
  • update go to 1.17

Related cn-infra PR: ligato/cn-infra#436

@ondrej-fabry
Add timeout for agentctl
43c144b 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Migrate fully to proto v2
05e2133 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Instantiate gomega handler for each test context
682d9c1 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry changed the title Migrate fully to protov2 feat: Migrate fully to protov2 Jan 19, 2022
@ondrej-fabry
Update go to 1.16 in CI workflow
018e9ae 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update cn-infra
b598009 
This change drops previously required replaces in go.mod for etcd and grpc.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Tidy up go.mod with go 1.17
86fba7e 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update go to 1.17
5240a8c 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
VladoLavor
VladoLavor previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@VladoLavor VladoLavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better cleanup would be nice, otherwise no issues

cmd/agentctl/commands/config.go Outdated Show resolved Hide resolved
cmd/agentctl/commands/generate.go Outdated Show resolved Hide resolved
pkg/models/models.go Outdated Show resolved Hide resolved
plugins/kvscheduler/internal/utils/record.go Outdated Show resolved Hide resolved
fgschwan
fgschwan requested changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@fgschwan fgschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+changes from Vlado (they are easy to do and help readability)

PS: i didn't review all the code yet, so this is only a partial review

cmd/agentctl/cli/flags.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
cmd/agentctl/commands/config.go Outdated Show resolved Hide resolved
plugins/restapi/handlers.go Outdated Show resolved Hide resolved
plugins/orchestrator/localregistry/initfileregistry.go Outdated Show resolved Hide resolved
client/local_client.go Outdated Show resolved Hide resolved
client/remoteclient/grpc_client.go Outdated Show resolved Hide resolved
client/remoteclient/grpc_client.go Outdated Show resolved Hide resolved
@ondrej-fabry
Update cn-infra to master
cf96d29 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Address review comments
551be03 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
fgschwan
fgschwan requested changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@fgschwan fgschwan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ the reopened resolved comment

pkg/models/item.go Outdated Show resolved Hide resolved
proto/ligato/kvscheduler/value_status.go Outdated Show resolved Hide resolved
proto/ligato/linux/interfaces/models.go Outdated Show resolved Hide resolved
proto/ligato/vpp/interfaces/models.go Outdated Show resolved Hide resolved
@ondrej-fabry
Remove commented code
b8ce289 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Fix RecordedProtoMessage
1c5d171 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Update comment
5c9ca0b 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry merged commit 68ab993 into master Jan 26, 2022
@ondrej-fabry ondrej-fabry deleted the proto2 branch January 26, 2022 11:36
@mhalaj1 mhalaj1 mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgschwan fgschwan fgschwan approved these changes

@VladoLavor VladoLavor VladoLavor left review comments

Assignees
No one assigned
Labels
🔗 dependencies ⚡️ feature 🔨 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ondrej-fabry @VladoLavor @fgschwan