fix: agentctl config history not working with remote models #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling agentctl config history, just query the remote models with grpc client and add them to the global default model registry. Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
ondrej-fabry
reviewed
Aug 3, 2022
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
ondrej-fabry
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling agentctl config history, just query the remote models with
grpc client and add them to the global default model registry.
Then when we unmarshal the messages we primarily use the default registry and
the proto global registry is used as a fallback.
Signed-off-by: Peter Motičák peter.moticak@pantheon.tech