fix: agentctl config dump not working with remote models #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
Use the RecordedKVWithMetadata type that can be properly un/marshalled from/to JSON. Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
* (Un)marshal RecordedProtoMessage as JSON instead of text * Add ability to create custom dump formats using templates for remote models * Fix the remaining agentctl e2e tests Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
|
is this ready for merge? |
|
Yes the fix itself works and should be ready for merge but it doesn't have an e2e test. The test could be added in a separate PR at a later time though. |
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
fgschwan
requested changes
Sep 12, 2022
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
fgschwan
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
agentctl config dumpto work with remote models (fix is very similar to fix: agentctl config history not working with remote models #1860)These changes (mainly the ModelList one) fix some problems with trailing slashes in remote model key prefixes (for example when running
agentctl model list/inspect).Signed-off-by: Peter Motičák peter.moticak@pantheon.tech