Version 0.0.123 #131
Merged
Version 0.0.123 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
force-pushed
the
version-0.0.123
branch
2 times, most recently
from
4be66a6
to
e36f0ac
Compare
tnull
reviewed
May 21, 2024
| @@ -30,13 +30,13 @@ class RegtestChannelManagerPersister : Persister, ExtendedChannelManagerPersiste | |||
| let fastFeerate = 7500 | |||
| let destinationScriptHardcoded: [UInt8] = [118,169,20,25,18,157,83,230,49,155,175,25,219,160,89,190,173,22,109,249,10,184,245,136,172] | |||
|
|
|||
| guard let result = self.keysManager?.spendSpendableOutputs(descriptors: outputs, outputs: [], changeDestinationScript: destinationScriptHardcoded, feerateSatPer1000Weight: UInt32(fastFeerate), locktime: nil) else { | |||
There was a problem hiding this comment.
Should we use the OutputSweeper instead here?
There was a problem hiding this comment.
nobody's using RegtestChannelManagerPersister anymore, but I can address it in a followup PR?
There was a problem hiding this comment.
I used an OutputSpender instead of the Sweeper.
There was a problem hiding this comment.
Alright, should work. It would be great to test the OutputSweeper works as expected in bindings eventually though.
There was a problem hiding this comment.
Wait, I'm confused. OutputSpender is a trait, so if you just init OutputSpender() it shouldn't do anything?
There was a problem hiding this comment.
whoa, you're right. Wtf's going on lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.