Use deterministic ordering of HashMaps when encoding a ChannelMonitor #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

benthecarman wants to merge 1 commit into lightningdevkit:main from benthecarman:deterministic-ordering

Contributor

benthecarman commented Dec 12, 2022

This makes the encoding of a ChannelMonitor reproducible, this should make testing easier among other things


          Use deterministic ordering of HashMaps when encoding a ChannelMonitor

f80b47f

Collaborator

TheBlueMatt commented Dec 12, 2022

Chatted about this on discord, would much rather do it via an Eq method, see #1912

TheBlueMatt closed this

benthecarman deleted the deterministic-ordering branch

December 12, 2022 21:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet