Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a sidecar ticket is cancelled, the person claiming never gets updated. #294

Closed
gkrizek opened this issue Oct 10, 2021 · 2 comments · Fixed by #304
Closed

When a sidecar ticket is cancelled, the person claiming never gets updated. #294

gkrizek opened this issue Oct 10, 2021 · 2 comments · Fixed by #304

Comments

@gkrizek
Copy link

gkrizek commented Oct 10, 2021

If you register a sidecar ticket, but the person that made the ticket cancels the order, the recipient's sidecar is still expecting a channel.

Expected behavior

When I have a sidecar ticket registered and the creator cancels the order, I expect my pool instance to know this happened and update the ticket status according.

Actual behavior

When I have a sidecar tickets registered and the person that created it cancels the order, my pool sidecar list command still shows the sidecar ticket as expecting channel. I would instead like it to transition to cancelled. I also see this in my receipint pool logs after the order is cancelled:

2021-10-09 19:01:21.805 [ERR] RPCS: [/poolrpc.Trader/CancelSidecar]: error canceling order 961526b127b69993ab7a51ae59bad2b0b0c63870a167f08246d75ffeaa401d2d for sidecar ticket cf59074b002a81d8: no order found

To reproduce

  • Create a sidecar ticket with Pool A
  • Redeem the sidecar ticket with Pool B
  • Cancel the sidecar ticket on Pool A

System information

macOS
poold version 0.5.1-alpha commit=v0.5.1-alpha-24-g9e5e1a8c52afa977e8f6b2e184b7ed0a6739f0a7

@Roasbeef
Copy link
Member

What I think we need to do here (assuming automated negotiation is used), is send over a new message over the messaging channel that indicates the ticket has been cancelled, so the receiving party can update their state. Thinking we might even want to add an expiration height to a given ticket (optionally) so that state will also eventually all be garbage collected.

@gkrizek
Copy link
Author

gkrizek commented Oct 11, 2021

Yes, this is with auto negotiation on. Sorry I forgot to mention that.

positiveblue pushed a commit to positiveblue/pool that referenced this issue Oct 11, 2022
order: use write lock in PutMarket, RemoveMarket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants