You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you register a sidecar ticket, but the person that made the ticket cancels the order, the recipient's sidecar is still expecting a channel.
Expected behavior
When I have a sidecar ticket registered and the creator cancels the order, I expect my pool instance to know this happened and update the ticket status according.
Actual behavior
When I have a sidecar tickets registered and the person that created it cancels the order, my pool sidecar list command still shows the sidecar ticket as expecting channel. I would instead like it to transition to cancelled. I also see this in my receipint pool logs after the order is cancelled:
2021-10-09 19:01:21.805 [ERR] RPCS: [/poolrpc.Trader/CancelSidecar]: error canceling order 961526b127b69993ab7a51ae59bad2b0b0c63870a167f08246d75ffeaa401d2d for sidecar ticket cf59074b002a81d8: no order found
To reproduce
Create a sidecar ticket with Pool A
Redeem the sidecar ticket with Pool B
Cancel the sidecar ticket on Pool A
System information
macOS poold version 0.5.1-alpha commit=v0.5.1-alpha-24-g9e5e1a8c52afa977e8f6b2e184b7ed0a6739f0a7
The text was updated successfully, but these errors were encountered:
What I think we need to do here (assuming automated negotiation is used), is send over a new message over the messaging channel that indicates the ticket has been cancelled, so the receiving party can update their state. Thinking we might even want to add an expiration height to a given ticket (optionally) so that state will also eventually all be garbage collected.
If you register a sidecar ticket, but the person that made the ticket cancels the order, the recipient's sidecar is still expecting a channel.
Expected behavior
When I have a sidecar ticket registered and the creator cancels the order, I expect my pool instance to know this happened and update the ticket status according.
Actual behavior
When I have a sidecar tickets registered and the person that created it cancels the order, my
pool sidecar list
command still shows the sidecar ticket asexpecting channel
. I would instead like it to transition tocancelled
. I also see this in my receipint pool logs after the order is cancelled:To reproduce
System information
macOS
poold version 0.5.1-alpha commit=v0.5.1-alpha-24-g9e5e1a8c52afa977e8f6b2e184b7ed0a6739f0a7
The text was updated successfully, but these errors were encountered: