sidecar: inform remote side about cancellation #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an instance of a "break" keyword that didn't have the desired effect (breaking out of the outer for loop). This didn't lead to an endless loop just because of the break in the error case a few lines above where we would leave the loop in case of an invalid state transition.
guggero
force-pushed
the
cancel-sidecar
branch
from
ecbd77e to
baee0e5
Compare
positiveblue
approved these changes
Oct 28, 2021
To avoid the other side waiting for an update for a ticket that will never come if it is canceled, we inform them instead.
To avoid running into an error during automatic bid order submission when offering a sidecar channel, we need to make the --min_chan_amt flag of the order mandatory.
guggero
force-pushed
the
cancel-sidecar
branch
from
baee0e5 to
856e09e
Compare
Roasbeef
reviewed
Nov 2, 2021
| return | ||
| } | ||
|
|
||
| // In every other case we can just remote the mailbox: |
| log.Errorf("unable to send cancel "+ | ||
| "msg to recipient: %v", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
I think we should fully tear down the goroutine here since at this point all negotiation has ceased. Same for the opposite role as well.
|
Gonna land this so we can proceed with some of the dependent merges, ideally can address those lingering commits in a follow up change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295.
Fixes #294.
This PR fixes the issue that when one side of a sidecar channel offering cancels the ticket, the other side isn't informed about it. This leads to follow-up errors on restarts and subsequent ticket submissions.
We solve this by sending a message to the other side if we are the cancelling party.
Because we send the message over the mailbox, we cannot remove it in that case.