rpcserver: format rpcLog error #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
force-pushed
the
fix-425
branch
from
88dbe89 to
499fc24
Compare
guggero
approved these changes
Jan 3, 2023
tools/Dockerfile
Outdated
| @@ -11,6 +11,7 @@ RUN cd /tmp \ | |||
| && mkdir -p /tmp/build/.modcache \ | |||
| && cd /tmp/tools \ | |||
| && go install -trimpath -tags=tools github.com/golangci/golangci-lint/cmd/golangci-lint \ | |||
| && chmod -R 777 /tmp/build/ | |||
| && chmod -R 777 /tmp/build/ \ | |||
| && git config --global --add safe.directory /build | |||
There was a problem hiding this comment.
Doesn't seem to be working just yet...
There was a problem hiding this comment.
Fixed in #427
I am still not sure how it can be solved in lnd without making the folder "safe" for git 😕
positiveblue
force-pushed
the
fix-425
branch
3 times, most recently
from
3e44bf4 to
4e2b5af
Compare
guggero
approved these changes
Jan 5, 2023
We were using `Error(<string>, <err>)` instead of `Errorf(<string>, <err>)`. The error was appended at the end of the message instead of replacing the `%v` tag in the message.
guggero
reviewed
Jan 6, 2023
| @@ -11,6 +11,9 @@ RUN cd /tmp \ | |||
| && mkdir -p /tmp/build/.modcache \ | |||
| && cd /tmp/tools \ | |||
| && go install -trimpath -tags=tools github.com/golangci/golangci-lint/cmd/golangci-lint \ | |||
| && chmod -R 777 /tmp/build/ | |||
| && chmod -R 777 /tmp/build/ \ | |||
| && git config --global --add safe.directory /build | |||
There was a problem hiding this comment.
I guess this was a rebase issue. I don't think we actually still need this.
There was a problem hiding this comment.
Yes it was T.T I will delete it in a next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Error(<string>, <err>)instead ofErrorf(<string>, <err>). The error was appended at the end of the message instead of replacing the%vtag in the message.Fixes #425