Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: format rpcLog error #426

Merged
merged 2 commits into from
Jan 6, 2023
Merged

rpcserver: format rpcLog error #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad3d2d9
ci: fix lint VSC permissions error
positiveblue Jan 4, 2023
5a5207d
rpcserver: format rpcLog error
positiveblue Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,9 @@ func (s *rpcServer) Stop() error {
}

// serverHandler is the main event loop of the server.
func (s *rpcServer) serverHandler(blockChan chan int32, blockErrChan chan error) {
func (s *rpcServer) serverHandler(blockChan chan int32,
blockErrChan chan error) {

defer s.wg.Done()

for {
Expand Down Expand Up @@ -275,7 +277,7 @@ func (s *rpcServer) serverHandler(blockChan chan int32, blockErrChan chan error)
}
}

rpcLog.Error("Unknown server error: %v", err)
rpcLog.Errorf("Unknown server error: %v", err)

case height := <-blockChan:
rpcLog.Infof("Received new block notification: "+
Expand Down
5 changes: 4 additions & 1 deletion tools/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ RUN cd /tmp \
&& mkdir -p /tmp/build/.modcache \
&& cd /tmp/tools \
&& go install -trimpath -tags=tools github.com/golangci/golangci-lint/cmd/golangci-lint \
&& chmod -R 777 /tmp/build/
&& chmod -R 777 /tmp/build/ \
&& git config --global --add safe.directory /build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was a rebase issue. I don't think we actually still need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was T.T I will delete it in a next PR

# The last line is needed to ensure that go build is able to gather
# information from the vsc used in the builds to get the commit hash.

WORKDIR /build