GitHub: fix release script by updating GH action #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gijswijs
approved these changes
Jul 24, 2024
| @@ -49,11 +49,10 @@ jobs: | |||
| run: make release tag=${{ env.RELEASE_VERSION }} | |||
|
|
|||
| - name: Create Release | |||
| uses: lightninglabs/gh-actions/action-gh-release@2021.01.25.00 | |||
| uses: lightninglabs/gh-actions/action-gh-release@2024.07.24.00 | |||
There was a problem hiding this comment.
nit: Why does the lnd commit refer to the gh-action by hash, and this commit by tag?
There was a problem hiding this comment.
Because Laolu merged before I was able to push the tag 😅
ffranr
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the creation of the GitHub release draft creation on tag push (see failed attempt here: )
I confirmed this works by pushing a tag to my personal fork of
lnd: https://github.com/guggero/lnd/actions/runs/10058716669/job/27802410976Corresponding
lndpull request: lightningnetwork/lnd#8927