-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: update vendored release script #8927
Conversation
This fixes the problem where releases wouldn't be created anymore due to the GitHub Action for creating the draft release being out of date.
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice🦾
This fixes the Coverage CI step by making sure the file system is in sync with the files pulled in through a Go submodule.
@ProofOfKeags I also pushed a tag This will fix the Goveralls run, for example: https://github.com/lightningnetwork/lnd/actions/runs/10062995488/job/27816765240?pr=8892 (a file was deleted in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
Merged the dep update here (see ref'd commit hash): lightninglabs/gh-actions#2 |
Depends on lightninglabs/gh-actions#2.
This fixes the problem where releases wouldn't be created anymore due to the GitHub Action for creating the draft release being out of date.
I've confirmed this works with the following run in my fork of the repository: https://github.com/guggero/lnd/actions/runs/10058716669/job/27802410976