docs: fix broadcast misspelling #9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yyforyongyu
requested changes
Nov 21, 2024
cmd/commands/peersrpc_active.go
Outdated
| @@ -45,7 +45,7 @@ var updateNodeAnnouncementCommand = cli.Command{ | |||
| Add or remove addresses where your node can be reached at, change the | |||
| alias/color of the node or enable/disable supported feature bits without | |||
| restarting the node. A node announcement with the new information will | |||
| be created and brodcasted to the network.`, | |||
| be created and broadcasted to the network.`, | |||
There was a problem hiding this comment.
nit: think this should be broadcast, link
There was a problem hiding this comment.
i went ahead and changed it here. however, i did a quick search over the code base and saw "broadcasted" is used all over. just fyi
There was a problem hiding this comment.
yeah those parts are incorrect, feel free to fix them in another PR
w3irdrobot
force-pushed
the
broadcast-misspelling
branch
from
668aac9
to
92975f7
Compare
w3irdrobot
force-pushed
the
broadcast-misspelling
branch
from
92975f7
to
da8c451
Compare
yyforyongyu
reviewed
Nov 22, 2024
discovery/gossiper_test.go
Outdated
| @@ -3996,7 +3996,7 @@ func TestIgnoreOwnAnnouncement(t *testing.T) { | |||
| } | |||
|
|
|||
| // Now do the local channelannouncement, node announcement, and channel | |||
| // update. No messages should be brodcasted yet, since we don't have | |||
| // update. No messages should be broadcasted yet, since we don't have | |||
There was a problem hiding this comment.
think we also need to correct this one and the rest introduced in this PR
w3irdrobot
force-pushed
the
broadcast-misspelling
branch
from
da8c451
to
7b16672
Compare
w3irdrobot
force-pushed
the
broadcast-misspelling
branch
from
7b16672
to
d3bff47
Compare
yyforyongyu
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes the misspelling of "brodcast" to "broadcast" in a few places. I wouldn't have worried about it, but it shows up in the output of
lncli peers updatenodeannouncement --help.Steps to Test
lncli peers updatenodeannouncement --help.Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.