Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broadcast misspelling #9290

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/commands/peersrpc_active.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ var updateNodeAnnouncementCommand = cli.Command{
Add or remove addresses where your node can be reached at, change the
alias/color of the node or enable/disable supported feature bits without
restarting the node. A node announcement with the new information will
be created and brodcasted to the network.`,
be created and broadcast to the network.`,
ArgsUsage: "[--address_add=] [--address_remove=] [--alias=] " +
"[--color=] [--feature_bit_add=] [--feature_bit_remove=]",
Flags: []cli.Flag{
Expand Down
2 changes: 1 addition & 1 deletion discovery/gossiper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3996,7 +3996,7 @@ func TestIgnoreOwnAnnouncement(t *testing.T) {
}

// Now do the local channelannouncement, node announcement, and channel
// update. No messages should be brodcasted yet, since we don't have
// update. No messages should be broadcast yet, since we don't have
// the announcement signatures.
select {
case err = <-ctx.gossiper.ProcessLocalAnnouncement(batch.chanAnn):
Expand Down
4 changes: 4 additions & 0 deletions docs/release-notes/release-notes-0.19.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,10 @@ The underlying functionality between those two options remain the same.
by replacing the word `argument` with `input` in the command description,
clarifying that the command requires interactive inputs rather than arguments.

- [Fixed a few misspellings](https://github.com/lightningnetwork/lnd/pull/9290)
of "broadcast" in the code base, specifically the `lncli peers updatenodeannouncement`
command documentation.

# Contributors (Alphabetical Order)

* Animesh Bilthare
Expand Down
4 changes: 2 additions & 2 deletions itest/lnd_channel_graph_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ func testNodeAnnouncement(ht *lntest.HarnessTest) {
}

// testUpdateNodeAnnouncement ensures that the RPC endpoint validates
// the requests correctly and that the new node announcement is brodcasted
// the requests correctly and that the new node announcement is broadcast
// with the right information after updating our node.
func testUpdateNodeAnnouncement(ht *lntest.HarnessTest) {
alice, bob := ht.Alice, ht.Bob
Expand Down Expand Up @@ -477,7 +477,7 @@ func testUpdateNodeAnnouncement(ht *lntest.HarnessTest) {
}

// Get dave default information so we can compare it lately with the
// brodcasted updates.
// broadcast updates.
resp := dave.RPC.GetInfo()
defaultAddrs := make([]*lnrpc.NodeAddress, 0, len(resp.Uris))
for _, uri := range resp.GetUris() {
Expand Down
2 changes: 1 addition & 1 deletion rpcserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ func (r *rpcServer) addDeps(s *server, macService *macaroons.Service,
routerBackend, s.nodeSigner, s.graphDB, s.chanStateDB,
s.sweeper, tower, s.towerClientMgr, r.cfg.net.ResolveTCPAddr,
genInvoiceFeatures, genAmpInvoiceFeatures,
s.getNodeAnnouncement, s.updateAndBrodcastSelfNode, parseAddr,
s.getNodeAnnouncement, s.updateAndBroadcastSelfNode, parseAddr,
rpcsLog, s.aliasMgr, r.implCfg.AuxDataParser,
invoiceHtlcModifier,
)
Expand Down
6 changes: 3 additions & 3 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -3250,11 +3250,11 @@ func (s *server) genNodeAnnouncement(features *lnwire.RawFeatureVector,
return *s.currentNodeAnn, nil
}

// updateAndBrodcastSelfNode generates a new node announcement
// updateAndBroadcastSelfNode generates a new node announcement
// applying the giving modifiers and updating the time stamp
// to ensure it propagates through the network. Then it brodcasts
// to ensure it propagates through the network. Then it broadcasts
// it to the network.
func (s *server) updateAndBrodcastSelfNode(features *lnwire.RawFeatureVector,
func (s *server) updateAndBroadcastSelfNode(features *lnwire.RawFeatureVector,
guggero marked this conversation as resolved.
Show resolved Hide resolved
modifiers ...netann.NodeAnnModifier) error {

newNodeAnn, err := s.genNodeAnnouncement(features, modifiers...)
Expand Down
Loading