Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14.0 Release #268

Merged
merged 4 commits into from
Feb 25, 2020
Merged

0.14.0 Release #268

merged 4 commits into from
Feb 25, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Feb 25, 2020

overcat and others added 4 commits February 19, 2020 17:10
Add support for SEP-10 including the latest multi-sig features that are in SEP-10 v1.3.0.
* feat: add support for `/offers` end-point with query parameters.

* feat: add support for `/accounts` end-point with ?signer and ?asset filters.

* feat: extend offer call builder to return a single offer.

* test: add more tests for account and offer endpoint.
@tamirms tamirms requested a review from abuiles February 25, 2020 19:19
@abuiles
Copy link
Contributor

abuiles commented Feb 25, 2020

@tamirms I think I forgot to list this, but can you include support for /offers/:offer_id too?

@@ -16,7 +16,7 @@ apply plugin: 'com.github.ben-manes.versions' // gradle dependencyUpdates -Drevi
apply plugin: 'project-report' // gradle htmlDependencyReport

sourceCompatibility = 1.6
version = '0.13.0'
version = '0.14.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamirms would it make sense to make this 1.0.0 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I don't think the sdk versions have to match horizon's version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't -- I was just suggesting also to add extra emphasis that there have been breaking changes through the latest release -- but I'm okay with this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what is worth none of the sdks match horizon's version :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think semver allows breaking changes without incrementing the major release if the version is less than 1.0.0

@tamirms tamirms merged commit f9c2ad0 into master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants