Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email from field should be RecNet #247

Closed
yoavartzi opened this issue May 22, 2024 · 0 comments
Closed

Email from field should be RecNet #247

yoavartzi opened this issue May 22, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Digest distributi...

Comments

@yoavartzi
Copy link
Member

Currently, the emails come from lil.recnet
They should just show "RecNet"
@yoavartzi yoavartzi added the enhancement New feature or request label May 22, 2024
@swh00tw swh00tw mentioned this issue Dec 4, 2024
Merged
2 tasks
swh00tw added a commit that referenced this issue Dec 9, 2024
@swh00tw
[recnet-api] Fix: change from field of email (#372)
bcb503a 
## Description

<!--- Describe your changes in detail -->
- The "From" field now is `lil.recnet@gmail.com` and we want it to be
`RecNet`
- Misc: add back email test api `POST /subscriptions/email/test`

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
- #247 

## Notes

<!-- Other thing to say -->

## Test

<!--- Please describe in detail how you tested your changes locally. -->
use `POST /subscriptions/email/test`

## Screenshots (if appropriate):

<!--- Add screenshots of your changes here -->

Comparison

![Screenshot 2024-12-04 at 1 48
43 PM](https://github.com/user-attachments/assets/1e867128-a538-46a9-9008-0c054693e8d3)

## TODO

- [ ] Clear `console.log` or `console.error` for debug usage
- [ ] Update the documentation `recnet-docs` if needed
@github-actions github-actions bot mentioned this issue Dec 9, 2024
Merged
swh00tw added a commit that referenced this issue Dec 10, 2024
@swh00tw
Release dev to master (#377)
2b09639 
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #374
- #373
- #247
## Related PRs
- #376
- #375
- #372
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
@swh00tw swh00tw closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Recnet Planning
Status: Done
Milestone
Digest distribution mechanism general...
Development

No branches or pull requests
2 participants
@yoavartzi @swh00tw