Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recnet-api] Fix: change from field of email #372

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

swh00tw
Copy link
Collaborator

@swh00tw swh00tw commented Dec 4, 2024

Description

  • The "From" field now is lil.recnet@gmail.com and we want it to be RecNet
  • Misc: add back email test api POST /subscriptions/email/test

Related Issue

Notes

Test

use POST /subscriptions/email/test

Screenshots (if appropriate):

Comparison

Screenshot 2024-12-04 at 1 48 43 PM

TODO

  • Clear console.log or console.error for debug usage
  • Update the documentation recnet-docs if needed

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
recnet ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 6:52pm
recnet-docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 6:52pm

Copy link
Collaborator

@joannechen1223 joannechen1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swh00tw swh00tw merged commit bcb503a into dev Dec 9, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
swh00tw added a commit that referenced this pull request Dec 10, 2024
## RecNet auto-release action
This is an auto-generated PR by recnet-release-action 🤖
Please make sure to test your changes in staging before merging. 
## Related Issues
- #374
- #373
- #247
## Related PRs
- #376
- #375
- #372
## Staging links
recnet-web:
[https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app](https://vercel.live/link/recnet-git-dev-recnet-542617e7.vercel.app)
recnet-api:
[https://dev-api.recnet.io/api](https://dev-api.recnet.io/api)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants